-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for retry event hook #50
Open
bodenr
wants to merge
6
commits into
rholder:master
Choose a base branch
from
bodenr:retry_log_hook
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on May 27, 2016
-
It's very common for consumers to perform some action on each attempt iteration; for example logging a message that the operation failed and a retry will be performed after some time. While this can be done today using a custom wait_func, it's inconvenient to use a partial to wrap an existing retrying sleep function just to get this behavior. This patch adds support for a new kwarg called wait_event_func that when passed should reference a function to be called before sleeping for another attempt iteration. This function looks similar to retrying wait_funcs except its first arg is the time to sleep as returned by the current 'wait' function. A handful of unit tests are also included.
Configuration menu - View commit details
-
Copy full SHA for 4400389 - Browse repository at this point
Copy the full SHA 4400389View commit details -
It's very common for consumers to perform some action on each attempt iteration; for example logging a message that the operation failed and a retry will be performed after some time. While this can be done today using a custom wait_func, it's inconvenient to use a partial to wrap an existing retrying sleep function just to get this behavior. This patch adds support for a new kwarg called wait_event_func that when passed should reference a function to be called before sleeping for another attempt iteration. This function looks similar to retrying wait_funcs except its first arg is the time to sleep as returned by the current 'wait' function. A handful of unit tests are also included.
Configuration menu - View commit details
-
Copy full SHA for 23ce674 - Browse repository at this point
Copy the full SHA 23ce674View commit details -
No assertIsNotNone() in py26 so change to a py26 compatible assert statement.
Configuration menu - View commit details
-
Copy full SHA for 6e1f680 - Browse repository at this point
Copy the full SHA 6e1f680View commit details
Commits on Jun 9, 2016
-
Merge branch 'retry_log_hook' of https://github.com/bodenr/retrying i…
…nto retry_log_hook Conflicts: test_retrying.py
Configuration menu - View commit details
-
Copy full SHA for 13a8dc2 - Browse repository at this point
Copy the full SHA 13a8dc2View commit details -
Merge branch 'master' into retry_log_hook
Conflicts: AUTHORS.rst retrying.py test_retrying.py
Configuration menu - View commit details
-
Copy full SHA for 49c29a1 - Browse repository at this point
Copy the full SHA 49c29a1View commit details
Commits on Jun 16, 2016
-
Configuration menu - View commit details
-
Copy full SHA for a76f32e - Browse repository at this point
Copy the full SHA a76f32eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.