Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove #test name comment from ks.in files #1341

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Nov 22, 2024

I am not aware of any purpose of this comment and it is difficult to keep in sync with the real test name. If at all it should be generated at some point.

For example in #1324 I suggested renaming of the test in the review, but the #test name was not updated during update of the PR. Instead requiring additional update I decided to handle it in an additional PR or to get rid of the comments completely.

I am not aware of any purpose of this comment and it is difficult to
keep in sync with the real test name. If at all it should be generated
at some point.
@M4rtinK
Copy link
Contributor

M4rtinK commented Nov 22, 2024

I think I faintly remember this was used to check what test you are actually running by looking at the kickstart the given VM is using. Otherwise in absence of other metadata, you only see the kickstart contents. But I'm not sure if this is really that relevant anymore with the way we run kickstart tests & even name the test VMs based on the test being run.

If we really need to, we can always quite easily generate the test name (and possibly other stuff) when we compile the test kickstart from fragments.

@rvykydal
Copy link
Contributor Author

I think I faintly remember this was used to check what test you are actually running by looking at the kickstart the given VM is using. Otherwise in absence of other metadata, you only see the kickstart contents. But I'm not sure if this is really that relevant anymore with the way we run kickstart tests & even name the test VMs based on the test being run.

If we really need to, we can always quite easily generate the test name (and possibly other stuff) when we compile the test kickstart from fragments.

Yes, agreed, I was thinking the same.

@rvykydal
Copy link
Contributor Author

/test-tmt

@rvykydal rvykydal merged commit 109a503 into rhinstaller:master Nov 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants