Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: do not run manual kickstart tests on PR #5136

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Sep 7, 2023

@rvykydal rvykydal force-pushed the do-not-run-manual-kickstart-tests-on-pr branch from 5d65f0d to 67d04b3 Compare September 7, 2023 08:17
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me, even if it's very minimalistic. For now, it's certainly enough of a step forward.

@VladimirSlavik
Copy link
Contributor

To expand on the minimalistic part: I believe this makes it so that one cannot run these tests, even if explicitly listed. However, that's fine, I think - one can run the tests locally after all. And this is miles better than having to look through the results for every. single. detail. on. every. test.

For a complete solution we'd have to add an argument to enable/disable this, parse the args in more detail for that, and add logic to select the skip array variable based on branch name.

@rvykydal
Copy link
Contributor Author

rvykydal commented Sep 7, 2023

@VladimirSlavik yes, it is very minimalistic. When I tried to think about more complex stuff I started to believe that having the --testtype and --skip-testtypes API already available via the comment, together with the info in https://github.com/rhinstaller/kickstart-tests/blob/master/containers/runner/skip-testtypes, should be enough for the user to construct the set on his own.

@VladimirSlavik
Copy link
Contributor

Yes, I agree it's too complex. There's also the issue of different ignore lists for different types of runs.

@rvykydal
Copy link
Contributor Author

rvykydal commented Sep 8, 2023

/kickstart-test --testtype smoke

@rvykydal rvykydal merged commit 113f8be into rhinstaller:master Sep 8, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f40 infrastructure Changes affecting mostly infrastructure
Development

Successfully merging this pull request may close these issues.

2 participants