Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y: Disable brltty when not needed #5043

Closed
wants to merge 1 commit into from
Closed

a11y: Disable brltty when not needed #5043

wants to merge 1 commit into from

Conversation

VladimirSlavik
Copy link
Contributor

@VladimirSlavik VladimirSlavik commented Aug 14, 2023 •
edited
Loading

It spams logs like mad about incompatible devices sometimes.

Here's the more detailed comment in code:

If we're virtualized boot.iso, stop brltty. Virtual machines won't have any specialized hardware attached. It could still spam logs very thoroughly about device confusion, which we don't want. On live, it is managed by gnome shell and we don't want to stop it.

Draft, because I would like to discuss this with somebody in the know, and didn't find them yet.

@VladimirSlavik
a11y: Disable brltty when not needed
fa799b0 
It spams logs like mad about incompatible devices sometimes.
@github-actions github-actions bot added the f39 label Aug 14, 2023
M4rtinK
M4rtinK approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks a lot for looking into this, the brltty log spam is sometimes very annoying & I wonder if sometimes it could even break things due to eq. log storage running out. So glad to see this being fixed. :)

@VladimirSlavik
Copy link
Contributor Author

The feedback I got was that this expectation is probably not correct :-/

@VladimirSlavik VladimirSlavik deleted the master-brltty-reduce-logspam branch August 24, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M4rtinK M4rtinK M4rtinK approved these changes

Assignees
No one assigned
Labels
f39
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VladimirSlavik @M4rtinK