Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timezone: for kickstart allow also timezones not offered by GUI #5346

Merged
merged 1 commit into from
Dec 6, 2023
Merged

timezone: for kickstart allow also timezones not offered by GUI #5346

merged 1 commit into from
Dec 6, 2023

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Nov 27, 2023 •
edited
Loading

Port of #1149 from RHEL 7.

TODO:

  • kickstart test

@rvykydal
Copy link
Contributor Author

/kickstart-test --testtype time

VladimirSlavik
VladimirSlavik approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

I assume we don't want to migrate to zoneinfo (as upstream) in a minor RHEL due to the changed list, right?

@rvykydal
Copy link
Contributor Author

rvykydal commented Nov 28, 2023 •
edited
Loading

LGTM, thank you.

I assume we don't want to migrate to zoneinfo (as upstream) in a minor RHEL due to the changed list, right?

I didn't find a reason why we should, so I'm trying to stay on a safer (afaik) side wrt changes in a minor release.

@VladimirSlavik
Copy link
Contributor

Agreed.

(That also means that we need to track the different valid timezone list as a change for RHEL 10.)

@rvykydal
Copy link
Contributor Author

kickstart test: rhinstaller/kickstart-tests#1032

@rvykydal
Copy link
Contributor Author

/kickstart-test --testtype smoke

@rvykydal @jkonecny12
timezone: for kickstart allow also timezones not offered by GUI
bb4ff36 
For example Japan, which is linked to Asia/Tokyo in Olson tz database,
and we offer only Asia/Tokyo in GUI.

Resolves: jira#RHEL-13150
@jkonecny12
Copy link
Member

/kickstart-test --testtype smoke

@jkonecny12 jkonecny12 added the ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). label Dec 6, 2023
@jkonecny12 jkonecny12 merged commit 0d9aba3 into rhinstaller:rhel-9 Dec 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirSlavik VladimirSlavik VladimirSlavik approved these changes

Assignees
No one assigned
Labels
ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). rhel-9
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rvykydal @VladimirSlavik @jkonecny12