Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anaconda-diskroot: wait before dying on media check fail #5292

Merged

Conversation

AdamWill
Copy link
Contributor

anaconda-diskroot: wait before dying on media check fail

If a modesetting driver has been loaded by the time the media
check happens, halting the system (as we currently do immediately
if the check fails) blanks the screen, which is confusing for
the user. This adds a warning message and a 12-hour wait before
the system is eventually halted, so the user can see the media
check failure and (presumably) reboot and fix the medium.

It also tweaks the text of the failure message not to call it a
"CD check", since it's not 1998 any more.

Resolves: rhbz#2246410

If a modesetting driver has been loaded by the time the media
check happens, halting the system (as we currently do immediately
if the check fails) blanks the screen, which is confusing for
the user. This adds a warning message and a 12-hour wait before
the system is eventually halted, so the user can see the media
check failure and (presumably) reboot and fix the medium.

It also tweaks the text of the failure message not to call it a
"CD check", since it's not 1998 any more.

Resolves: rhbz#2246410

Signed-off-by: Adam Williamson <[email protected]>
@github-actions github-actions bot added the f39 label Oct 30, 2023
@AdamWill
Copy link
Contributor Author

cross-reference with dracutdevs/dracut#2545 , the same change in dracut (for the live path).

@AdamWill
Copy link
Contributor Author

btw, I'm not sure this is the best long-term fix, I was hoping someone had a better idea somehow. But I thought it was good enough for F39 at least, and wanted to submit it upstream before doing the downstream build.

@VladimirSlavik
Copy link
Contributor

Is there any reasoning behind the 12 hours?

@VladimirSlavik
Copy link
Contributor

/kickstart-test --testtype smoke

@AdamWill
Copy link
Contributor Author

AdamWill commented Nov 3, 2023

Is there any reasoning behind the 12 hours?

Kinda, but it's ultimately pretty arbitrary. I was talking the issue over with @nirik (I asked for his thoughts on whether he preferred a sleep or just dropping to the emergency console) and he suggested it. I'd considered anything from one minute upwards. The scenario we're concerned about is someone starting the media check then going to do something else; we want them to see the error when they come back. So, how long to leave it? It's hard to say. I figure at least half an hour in case they go for lunch and get distracted, or something. But then if you're gonna leave it that long, why not...longer?

Ultimately it's an arbitrary number. I'm not honestly sure this is the perfect fix for this, but we needed something for F39. The dracut folks had the same question over in dracutdevs/dracut#2545 .

@M4rtinK
Copy link
Contributor

M4rtinK commented Nov 15, 2023

Do we want to move this to Rawhide maybe ?

@AdamWill
Copy link
Contributor Author

AdamWill commented Nov 15, 2023

logically speaking it should be merged to F39 because I put it into F39 Final as a downstream patch. it wouldn't make much sense to remove it again with the next official F39 build. edit: that is, if we're going to merge it at all, it doesn't make sense to me to only merge it into Rawhide - since it already went into F39, F39 should keep it. If you think it was a terrible idea and you don't want to merge it anywhere and I shouldn't have put it in F39 Final, that's a different story. :D

Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this apply to kickstart installation?

@AdamWill
Copy link
Contributor Author

AdamWill commented Dec 4, 2023

Well, I would assume yes. But only if you set mediacheck to true, which is not the default.

@VladimirSlavik VladimirSlavik merged commit ec717fb into rhinstaller:fedora-39 Dec 6, 2023
14 checks passed
@VladimirSlavik
Copy link
Contributor

A release is not needed, since this is patched in f39 already. I will port it to master as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants