Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: bump Cockpit version of testlib #5275

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

KKoukiou
Copy link
Contributor

…enshots

This was introduced when the built in helper was in place, but no longer
required.
To include cockpit-project/cockpit@7baca28

Remove unused dependency po2json.
Instead explicitly require gettext-parser module needed by cockpit-po-plugin.
Bump esbuild-replace-plugin dependenncy.

Update js-error pixel tests with new font weight for the error detail;
this change is a result of: cockpit-project/cockpit@ea7acc
Wait for the "Report issue" button to become clickable before taking a
screenshot.
@KKoukiou
Copy link
Contributor Author

/kickstart-test --waive webui-only

Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@KKoukiou KKoukiou merged commit a8a3b36 into rhinstaller:master Oct 26, 2023
17 checks passed
@KKoukiou KKoukiou deleted the bump-testlib branch October 26, 2023 13:22
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants