-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webui: bump Cockpit version of testlib #5275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
force-pushed
the
bump-testlib
branch
2 times, most recently
from
October 24, 2023 09:56
28b706f
to
3f6baf2
Compare
This was referenced Oct 24, 2023
KKoukiou
force-pushed
the
bump-testlib
branch
6 times, most recently
from
October 25, 2023 15:20
0748cab
to
a68c941
Compare
…enshots This was introduced when the built in helper was in place, but no longer required.
To include cockpit-project/cockpit@7baca28 Remove unused dependency po2json. Instead explicitly require gettext-parser module needed by cockpit-po-plugin. Bump esbuild-replace-plugin dependenncy. Update js-error pixel tests with new font weight for the error detail; this change is a result of: cockpit-project/cockpit@ea7acc
Wait for the "Report issue" button to become clickable before taking a screenshot.
…ror messages Expect these in the test.
KKoukiou
force-pushed
the
bump-testlib
branch
from
October 26, 2023 11:22
a68c941
to
7b1a5ae
Compare
KKoukiou
force-pushed
the
bump-testlib
branch
from
October 26, 2023 11:53
7b1a5ae
to
6c71daf
Compare
/kickstart-test --waive webui-only |
VladimirSlavik
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you!
M4rtinK
reviewed
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as well, thanks! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To include cockpit-project/cockpit@7baca28