Skip to content

Commit

Permalink
infra: Allow webui tests for external contributors
Browse files Browse the repository at this point in the history
Currently, we need to manually execute web UI tests for external
contributors on each Anaconda PR. This is security precaution to avoid
malicious code to be executed on Cockpit runners.

However, our project is configured that we need to manually allow all
the workflows by pressing a button for every tests run for external
contributors. The webui case is making the same requirement twice for
this specific test.

To avoid unnecessary burden with not giving us much benefit, let's allow
external contributors for every run automatically. Press of the GitHub
button on PR should be good enough confirmation that there is no
malicious code.
  • Loading branch information
jkonecny12 committed Nov 27, 2024
1 parent dcd2002 commit ea6839e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/trigger-webui.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,4 +70,4 @@ jobs:
git clone --depth=1 https://github.com/cockpit-project/bots
mkdir -p ~/.config/cockpit-dev
echo '${{ secrets.GITHUB_TOKEN }}' > ~/.config/cockpit-dev/github-token
bots/tests-trigger --repo ${{ github.repository }} ${{ github.event.number }} fedora-rawhide-boot/anaconda-pr-${{ github.event.number }}@rhinstaller/anaconda-webui
bots/tests-trigger --allow --repo ${{ github.repository }} ${{ github.event.number }} fedora-rawhide-boot/anaconda-pr-${{ github.event.number }}@rhinstaller/anaconda-webui
2 changes: 1 addition & 1 deletion .github/workflows/trigger-webui.yml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,5 @@ jobs:
git clone --depth=1 https://github.com/cockpit-project/bots
mkdir -p ~/.config/cockpit-dev
echo '${{ secrets.GITHUB_TOKEN }}' > ~/.config/cockpit-dev/github-token
bots/tests-trigger --repo ${{ github.repository }} ${{ github.event.number }} fedora-rawhide-boot/anaconda-pr-${{ github.event.number }}@rhinstaller/anaconda-webui
bots/tests-trigger --allow --repo ${{ github.repository }} ${{ github.event.number }} fedora-rawhide-boot/anaconda-pr-${{ github.event.number }}@rhinstaller/anaconda-webui
{% endif %}

0 comments on commit ea6839e

Please sign in to comment.