Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: spectraData,spectraData<- to support also data.frame or other two-dimensional data structues #248

Open
jorainer opened this issue Oct 19, 2022 · 0 comments

Comments

@jorainer
Copy link
Member

This question came up during the review for PR #247 :

Should we restrict the spectraData and spectraData<- methods to exclusively return/accept a DataFrame?

Some backends, specifically those that store the data in a data.frame or a database need to convert data to/from DataFrame which can be inefficient. Maybe it would be better to relax the definition in the MsBackend API to support more two-dimensional data structures such as data.frame, DataFrame (tibble?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant