Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import zip-to-utility from HERO #614

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Import zip-to-utility from HERO #614

merged 1 commit into from
Nov 27, 2024

Conversation

oyamauchi
Copy link
Member

Description

I've loaded the contents of zip-to-utility.csv as they are now into
the HERO DB, which will now be the source of truth for it. I ran an
import and that's where the changes to zip-to-utility.csv come from.

This also deletes the generate-utility-data.ts script and associated
files. I do anticipate fishing these back out of version control at
some point, for various reasons, but for now I'm deleting them to
avoid confusion.

Test Plan

Run an import successfully.

Write a throwaway script to verify that the data in the old CSV file
and the new one is identical except for ordering.

## Description

I've loaded the contents of zip-to-utility.csv as they are now into
the HERO DB, which will now be the source of truth for it. I ran an
import and that's where the changes to zip-to-utility.csv come from.

This also deletes the `generate-utility-data.ts` script and associated
files. I do anticipate fishing these back out of version control at
some point, for various reasons, but for now I'm deleting them to
avoid confusion.

## Test Plan

Run an import successfully.

Write a throwaway script to verify that the data in the old CSV file
and the new one is identical except for ordering.
Copy link
Member

@veekas veekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@oyamauchi oyamauchi merged commit a5d66ca into main Nov 27, 2024
1 check passed
@oyamauchi oyamauchi deleted the owen.zip-scripts branch November 27, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants