Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incentive Admin Update #604

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Incentive Admin Update #604

merged 2 commits into from
Nov 14, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 1, 2024

This PR updates the API data files, using data maintained by the Incentive Admin.

@veekas
Copy link
Member

veekas commented Nov 1, 2024

Surprised by the number of changes here... does this generally look correct to you, @mpusto ?

@veekas veekas requested a review from mpusto November 1, 2024 20:05
@mpusto
Copy link

mpusto commented Nov 1, 2024

Interesting! The OH, DE, GA, and DC updates are all things that I did, so they look fine. I think Sarah was going to work on some CO ones, so that might explain those. For NV, MI, VT, and WI I don't know what is going on there. Some of them look like there weren't really updates?

@mpusto
Copy link

mpusto commented Nov 1, 2024

Ahhh, I see what happened. When @oyamauchi removed the field for "bonus" all the records that had it show as "changed".

Copy link

@mpusto mpusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, my changes are in there and the bonus ones are fine as well.

@oyamauchi
Copy link
Member

Right, yes, the bonus_available and representative fields being deleted is expected. I probably should have done an export right after landing that migration, to get those changes out of the way.

},
"owner_status": [
"homeowner"
],
"short_description": {
"en": "Rebate for 50% of cost up to $500 for ENERGY STAR® certified heat pump water heaters.",
"es": "Reembolso del 50% de los costos para calentadores de agua con bomba de calor certificados ENERGY STAR, hasta $500 dólares."
"en": "Rebate for 50% of cost up to $100 for ENERGY STAR® certified heat pump water heaters.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$1000

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed back to $500 to match the official language (i.e. they're willing to subsidize the cost of a heat pump water heater by up to $500 assuming the homeowner spent at least $1000 overall)

@github-actions github-actions bot force-pushed the incentive-admin-update branch 2 times, most recently from f51a79c to d57dc66 Compare November 7, 2024 14:05
@veekas veekas enabled auto-merge (squash) November 7, 2024 14:15
@veekas veekas disabled auto-merge November 7, 2024 14:15
@veekas veekas enabled auto-merge (squash) November 7, 2024 14:15
@veekas veekas merged commit 06825cd into main Nov 14, 2024
1 check passed
@veekas veekas deleted the incentive-admin-update branch November 14, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants