Fix bug with filtering items in IRA incentives #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Reported in #525 The assumption that `items` is a singleton for IRA incentives was broken a while ago. This meant that some IRA incentives were incorrectly getting filtered out, because only `items[0]` was being checked for overlap with `request.items`, rather than all of them. The first-party calculator wasn't affected by this, because it passes all the items in every query. ## Test Plan `yarn test`. This case was being exercised by an existing snapshot test. The bug was introduced in 77d0ff6 and I dutifully updated the snapshot there, but didn't notice the problem.
matelau
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reported in #525
The assumption that
itemsis a singleton for IRA incentives wasbroken a while ago. This meant that some IRA incentives were
incorrectly getting filtered out, because only
items[0]was beingchecked for overlap with
request.items, rather than all of them.The first-party calculator wasn't affected by this, because it passes
all the items in every query.
Test Plan
yarn test. This case was being exercised by an existing snapshottest. The bug was introduced in 77d0ff6 and I dutifully updated the
snapshot there, but didn't notice the problem.