Override "City of Eugene" (OR) with municipal utility name #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're pretty consistently branded as "EWEB" (https://www.eweb.org/) so going with that rather than spelling it out.
rpartridge
approved these changes
Jul 1, 2024
Comment on lines
+296
to
+297
| [6022, 'EWEB'], // Eugene Water & Electric Board | ||
| [430373, 'EWEB'], |
There was a problem hiding this comment.
it's been a while since I've worked on this... remind me why we need line 297 as well? are there 2 records for this utility in the energy star data set?
There was a problem hiding this comment.
Yeah there are two different utility IDs for EWEB, for some reason. One of them (430373) is only associated with what seems to be a non-real zip code (00069); I don't know what's going on with that, but I figure there's no harm in overriding both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're pretty consistently branded as "EWEB" (https://www.eweb.org/)
so going with that rather than spelling it out.