Problems with 0.3.0/0.3.1

[knalli]

Okay, because of the issue #214, my plan was upgrading the thing. Unfortunately, there are a lot of breaking changes.

a) In the past we add a static list of slides (simple content), and the indicators were built according this. This works not any more, because the indicators relies on attribute slides only.
b) In the past we could use any kind of elements.. now this is forced only to ul/li. I do not see any gain..

And a real bug is (for mine), that the Tweenable export seems to be damaged. Sometimes Tweenable is only empty (because exported as null), or the whole animations are really broken (stopping where my mouse is, even if I have not clicked yet??)

[knalli]

Workaround for a)

<div ng-init="slides=['a','b','c']">
<ul rn-carousel>
<li ng-repeat="slide in slides">
<div class="content-{{slide}}"></div>
</li>
</ul>
</div>

[revolunet]

Thanks for reporting and sorry for the breaking changes.

a) yes you just need to give indicators@slides an array with the same number of slides
b) yes we're limited to ul/li at the moment.

For Tweenable this is very annoying. which browser/os ? i dont have this kind of problems using the dist version.

the ios issue should be solvd

[knalli]

I am using the dist non minified

angular-carousel/dist/angular-carousel.js

Line 1991 in 01ebfec

return this.Tweenable;

(this.Tweenable == undefined).

Just verified: same issue with the minified one.

which browser/os ?

OS X 10.9 + Chrome/Firefox

But your demos at http://blog.revolunet.com/angular-carousel are working fully. I will make a standalone version tomorrow, right now I cannot see a difference.

[revolunet]

if you can reproduce online i can look deeper

[knalli]

Sorry for the delay.

Gotcha. I have a RequireJS env, which causes to break in

angular-carousel/dist/angular-carousel.js

Lines 1059 to 1061 in 528405e

	} else if (typeof define === 'function' && define.amd) {
	// AMD
	define(function () {return Tweenable;});

I would suggest you use a correct inline version.

[rorykoehein]

I think I'm having a similar issue. I'm not using RequireJS. I'm getting this error in Chrome.

Provider 'Tweenable' must return a value from $get factory method.

I think it's because the Tweenable Factory is returning this.Tweenable before the function inside of it is done. So at the moment of return, this.Tweenable is undefined. Sort of a race-condition/async problem. The function will run, but JS will go on to the next line: the return statement.

When I change line 7 of shifty.js to:

return (function (root) {

and line 1379 to:

return Tweenable;

Then it works. I'm sorry I have no time for a pull-request at the moment.

*edit: I'm getting this with Angular 1.3.0

[revolunet]

a contributor fixed the problem in the 0.3.4 version. can you confirm please ?

[knalli]

Looks good, cannot update completely (running out of time today), but applied to my patch days ago it is working.

[Skrewtape]

FYI, it looks like this problem came back in 0.3.7, due to an upgrade of Tweenable.

[revolunet]

Yes. can someone help me at this please ? i dont know requirejs :/ ping @jakeauyeung

[jakeauyeung]

@revolunet my project seed ,use requirejs and angularjs. https://github.com/jakeauyeung/angularjs-requirejs-seed-for-project

[rodrigoreis22]

I'm using v 0.3.7 and requirejs, and I'm having the same problem.

[davidvartanian]

My application runs Angular with RequireJS. I also confirm the issue on v0.3.7, but v0.3.6 works fine.