Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Severity is not being passed from golangci-lint into reviewdog #110

Open
algojack opened this issue Aug 18, 2021 · 1 comment
Open

Severity is not being passed from golangci-lint into reviewdog #110

algojack opened this issue Aug 18, 2021 · 1 comment

Comments

@algojack
Copy link

algojack commented Aug 18, 2021

When we do --out-format line-number the word error, warning, etc doesn’t appear. So golangci-lint is not telling reviewdog the severity of any issues, and setting default severity: warning in the golangci-lint config doesn’t have any effect.

The work around is to use the “checkstyle” format. Which is an XML format supported by both reviewdog and golangci-lint that includes a severity=“XXX” field.

['run', '--out-format', 'line-number', ...flags.parse(golangciLintFlags)],

@vinita-razor
Copy link

@algojack What should be the errorformat for "checkstyle" format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants