Skip to content
This repository has been archived by the owner on Jun 6, 2020. It is now read-only.

refactor(dpi): check for errors in SDL_GetDisplayDPI #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor(dpi): check for errors in SDL_GetDisplayDPI #78

wants to merge 2 commits into from

Conversation

taylon
Copy link

@taylon taylon commented Jun 5, 2020 •
edited
Loading 

<breaking>Potential errors from SDL_GetDisplayDPI are now captured so Display.getDPI now returns a Result</breaking>

@taylon taylon mentioned this pull request Jun 5, 2020
Open
glennsl
glennsl reviewed Jun 5, 2020
View reviewed changes
examples/basic.re Outdated Show resolved Hide resolved
@taylon @glennsl
Update examples/basic.re
095c086 
Co-authored-by: Glenn Slotte <[email protected]>
@Et7f3
Copy link
Member

Et7f3 commented Jun 5, 2020

Wait it is now in a monorepo in revery ....

@glennsl
Copy link
Member

glennsl commented Jun 6, 2020

Oh, lol, yeah it is! We really ought to archive these projects and point to the monorepo folder. Or a section in the revery README that explains the monorepo structure.

I can't see that I have permission to do this, so @bryphe?

@bryphe
Copy link
Member

bryphe commented Jun 6, 2020

Sorry about that, @taylon ! I'll archive this now and redirect to avoid confusion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@glennsl glennsl glennsl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taylon @Et7f3 @glennsl @bryphe