-
Notifications
You must be signed in to change notification settings - Fork 10
Reduce deps #59
base: master
Are you sure you want to change the base?
Reduce deps #59
Conversation
227848f
to
ddefb71
Compare
I have force pushed because I have forgotten to remove dune@<2.1 to test [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Works when linked locally to Revery
- Example runs (
esy @example run
)
However, trying to build with esy @js
fails with:
info building @opam/js_of_ocaml-lwt@opam:3.5.2@6ea3e3c2: done
ocamlc bin_js/test_sdl2.bc (exit 2)
(cd /Users/ter/dev/diverse/reason/reason-sdl2/_esy/js/store/b/reason_sdl2-80afa601/default && /Users/ter/.esy/3_____________________________________________________________________/i/ocaml-4.9.0-27f2b357/bin/ocamlc.opt -w -40 -g -o bin_js/test_sdl2.bc /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__js__of__ocaml-opam__c__3.5.2-b18b0af9/lib/js_of_ocaml/js_of_ocaml.cma /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__result-opam__c__1.5-e2b3383e/lib/result/result.cma /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__lwt-opam__c__5.2.0-11443f49/lib/lwt/lwt.cma /Users/ter/.esy/3_____________________________________________________________________/i/ocaml-4.9.0-27f2b357/lib/ocaml/unix.cma /Users/ter/.esy/3_____________________________________________________________________/i/ocaml-4.9.0-27f2b357/lib/ocaml/bigarray.cma src/sdl2.cma -I src /Users/ter/.esy/3_____________________________________________________________________/i/reason_native__s__console-0.1.0-c22d4f3f/lib/console/lib/Console.cma examples/sdl2example.cma bin_js/.test_sdl2.eobjs/byte/test_sdl2.cmo)
File "_none_", line 1:
Error: Error on dynamically loaded library: ./src/dllsdl2_stubs.so: dlopen(./src/dllsdl2_stubs.so, 10): Symbol not found: _NSApp
Referenced from: ./src/dllsdl2_stubs.so
Expected in: flat namespace
in ./src/dllsdl2_stubs.so
error: command failed: 'dune' 'build' '-p' 'sdl2,sdl2-js' (exited with 1)
esy-build-package: exiting with errors above...
error: build failed with exit code: 1
esy: exiting due to errors above
EDIT:
On master esy @js
gives the following:
❯ esy @js
info esy 0.7.0-66428e (using js.json)
File "bin_js/dune", line 4, characters 21-28:
4 | (preprocess (pps lwt_ppx))
^^^^^^^
Error: Library "lwt_ppx" not found.
Hint: try: dune external-lib-deps --missing --root . @@default
error: command failed: 'dune' 'build' '--root' '.' (exited with 1)
esy-build-package: exiting with errors above...
error: build failed with exit code: 1
esy: exiting due to errors above
Should we do something about the JS-build? @Et7f3 |
I really don't know what happen here. I will try to investigate after. |
@lessp on master can you add: |
We had similar issuer with sdl https://discordapp.com/channels/526111832478449695/532721901886504981/676493496575590417 |
Can confirm it builds on master when adding this to |
d8c339c
to
380164a
Compare
Co-Authored-By: Tom Ekander <[email protected]>
Ok I am rebasing because a unused deps was already removed d679957 |
This PR remove dependencies on refmterr (used only at build time) and esy-cmake 👀 I wonder why it was their.
Rationale: I have low disk space on my linux partition so try to reduce revery size globally. Another reason: less dependencies mean more easier to update. Now to publish to opam we need to publish our patched esy-sdl2 and this package is ready.