Skip to content
This repository has been archived by the owner on Jun 6, 2020. It is now read-only.

Reduce deps #59

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Reduce deps #59

wants to merge 3 commits into from

Conversation

Et7f3
Copy link
Member

@Et7f3 Et7f3 commented Apr 12, 2020

This PR remove dependencies on refmterr (used only at build time) and esy-cmake 👀 I wonder why it was their.

Rationale: I have low disk space on my linux partition so try to reduce revery size globally. Another reason: less dependencies mean more easier to update. Now to publish to opam we need to publish our patched esy-sdl2 and this package is ready.

@Et7f3 Et7f3 changed the title Et7f3 reduce deps Reduce deps Apr 12, 2020
@Et7f3 Et7f3 force-pushed the Et7f3-reduce-deps branch from 227848f to ddefb71 Compare April 12, 2020 10:22
@Et7f3
Copy link
Member Author

Et7f3 commented Apr 12, 2020

I have force pushed because I have forgotten to remove dune@<2.1 to test [email protected]

@Et7f3 Et7f3 marked this pull request as ready for review April 12, 2020 10:24
@Et7f3 Et7f3 requested a review from lessp April 12, 2020 10:24
Copy link
Member

@lessp lessp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Works when linked locally to Revery
  • Example runs (esy @example run)

However, trying to build with esy @js fails with:

info building @opam/js_of_ocaml-lwt@opam:3.5.2@6ea3e3c2: done
      ocamlc bin_js/test_sdl2.bc (exit 2)
(cd /Users/ter/dev/diverse/reason/reason-sdl2/_esy/js/store/b/reason_sdl2-80afa601/default && /Users/ter/.esy/3_____________________________________________________________________/i/ocaml-4.9.0-27f2b357/bin/ocamlc.opt -w -40 -g -o bin_js/test_sdl2.bc /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__js__of__ocaml-opam__c__3.5.2-b18b0af9/lib/js_of_ocaml/js_of_ocaml.cma /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__result-opam__c__1.5-e2b3383e/lib/result/result.cma /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__lwt-opam__c__5.2.0-11443f49/lib/lwt/lwt.cma /Users/ter/.esy/3_____________________________________________________________________/i/ocaml-4.9.0-27f2b357/lib/ocaml/unix.cma /Users/ter/.esy/3_____________________________________________________________________/i/ocaml-4.9.0-27f2b357/lib/ocaml/bigarray.cma src/sdl2.cma -I src /Users/ter/.esy/3_____________________________________________________________________/i/reason_native__s__console-0.1.0-c22d4f3f/lib/console/lib/Console.cma examples/sdl2example.cma bin_js/.test_sdl2.eobjs/byte/test_sdl2.cmo)
File "_none_", line 1:
Error: Error on dynamically loaded library: ./src/dllsdl2_stubs.so: dlopen(./src/dllsdl2_stubs.so, 10): Symbol not found: _NSApp
  Referenced from: ./src/dllsdl2_stubs.so
  Expected in: flat namespace
 in ./src/dllsdl2_stubs.so
error: command failed: 'dune' 'build' '-p' 'sdl2,sdl2-js' (exited with 1)
esy-build-package: exiting with errors above...
error: build failed with exit code: 1
  
esy: exiting due to errors above

EDIT:

On master esy @js gives the following:

❯ esy @js
info esy 0.7.0-66428e (using js.json)
File "bin_js/dune", line 4, characters 21-28:
4 |     (preprocess (pps lwt_ppx))
                         ^^^^^^^
Error: Library "lwt_ppx" not found.
Hint: try: dune external-lib-deps --missing --root . @@default
error: command failed: 'dune' 'build' '--root' '.' (exited with 1)
esy-build-package: exiting with errors above...
error: build failed with exit code: 1
  
esy: exiting due to errors above

package.json Outdated Show resolved Hide resolved
@lessp
Copy link
Member

lessp commented Apr 14, 2020

Should we do something about the JS-build? @Et7f3

@Et7f3 Et7f3 marked this pull request as draft April 14, 2020 17:52
@Et7f3
Copy link
Member Author

Et7f3 commented Apr 14, 2020

I really don't know what happen here. I will try to investigate after.

@Et7f3
Copy link
Member Author

Et7f3 commented Apr 14, 2020

@lessp on master can you add: "@opam/lwt_ppx": "^2.0.0",

@Et7f3
Copy link
Member Author

Et7f3 commented Apr 14, 2020

@lessp
Copy link
Member

lessp commented Apr 15, 2020

"@opam/lwt_ppx": "^2.0.0"

Can confirm it builds on master when adding this to js.json

@Et7f3 Et7f3 force-pushed the Et7f3-reduce-deps branch from d8c339c to 380164a Compare April 22, 2020 19:56
@Et7f3
Copy link
Member Author

Et7f3 commented May 7, 2020

Ok I am rebasing because a unused deps was already removed d679957

@Et7f3 Et7f3 force-pushed the Et7f3-reduce-deps branch from 380164a to fd0e5a7 Compare May 7, 2020 12:01
@Et7f3 Et7f3 force-pushed the Et7f3-reduce-deps branch from fd0e5a7 to 206b585 Compare May 7, 2020 12:04
@Et7f3 Et7f3 mentioned this pull request May 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants