Initial refactor for more sane pan events #11
Conversation
|
CC @glennsl for design approach (continuation of discussion in revery-ui/revery#766) CC @Et7f3 for any C89 dumbness I've overlooked |
|
CI failure expected, need to fix the waylandevents usage of PanEvent |
|
Not entirely sure what I'm looking at, since it seems like there's even syntax errors in I don't understand why the source is a separate pan type. I thought that was a field common to every type of event. And if it is, it looks like |
|
Forgot to commit some more recent stuff, syntax errors should at least be fixed lol. The source isn't actually possible to provide in the same event for wayland, since it's split out into its own event. If events are assumed to use the source from any prior events this should work. It might make sense to special case wayland for this and store the current source into a static var and plug that into any events that are dispatched. |
|
Oh, that's weird. But that assumption has to be made somewhere, right? Might as well make it as early as possible. |
|
@glennsl should be slightly better now |
in line with docs, negative error code allows more info Co-Authored-By: Et7f3 <[email protected]>
Co-Authored-By: Et7f3 <[email protected]>
…sdl2 into better_panevents
Co-Authored-By: Et7f3 <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Those mojave checks didn't rerun, and were last run in april. Is something going on with CI? |
https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops&tabs=yaml ``` macOS X Mojave 10.14 macOS-10.14 macOS-10.14 Link macOS X Catalina 10.15 macOS-10.15 macOS-latest OR macOS-10.15 Link ```
|
mojave was a bad name of 10.13 and not supported anymore in azure. |
Refactor pan events as the "kitchen sink" approach to representing events really doesn't generalize well to less verbose reprs (wayland, cocoa), while a more slimmed repr can generalize fairly well to more verbose reprs (windows)