Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soft_delete_columns() potentially misleading api for users #40

Open
HoffsMH opened this issue May 11, 2019 · 1 comment
Open

soft_delete_columns() potentially misleading api for users #40

HoffsMH opened this issue May 11, 2019 · 1 comment

Comments

@HoffsMH
Copy link

HoffsMH commented May 11, 2019

If the function only adds a single column to a table then might we want to change the name to
soft_delete_column?

I didn't want to open up multiple PRs at a time but if I have the go ahead I have a branch ready.

I think that a change like this actually has some dangers.
Since the only files that this function will be called in are migration files and it is generally frowned upon to edit migration files after checking them into source control.

If the api changes it should be backwards compatible and only the documentation should change with it.

I would consider deprecation warnings for the plural version but I wonder if that would be detrimental in terms of encouraging developers to edit migration files.

Feedback appreciated but not expected after all it is just a naming issue! 😄

@bryanjos
Copy link
Contributor

I think I left it open just in case we added something else. I almost thought about removing it completely since it doesn't do much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants