Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FB 2/N: Feebump coins tracking #8

Open
darosior opened this issue Oct 5, 2021 · 5 comments
Open

FB 2/N: Feebump coins tracking #8

darosior opened this issue Oct 5, 2021 · 5 comments
Assignees

Comments

@darosior
Copy link
Member

darosior commented Oct 5, 2021

Do we want a watchonly wallet? To use scantxoutset? Or even a non-watchonly Bitcoin wallet?

@JSwambo
Copy link
Member

JSwambo commented Dec 17, 2021

The feebump wallet should be a regular (non-watchonly) Bitcoin wallet because the WT has the private keys and needs to use them to sign additional feebump inputs

Edit: now thinking about signing and bumping the fee... I think we'll need to do this through revault_tx not through bitcoind rpc... if so then feebumping wallet should be watchonly.

@darosior
Copy link
Member Author

darosior commented Dec 17, 2021 via email

@JSwambo
Copy link
Member

JSwambo commented Dec 17, 2021

No I don't think so... see edit ^

@JSwambo
Copy link
Member

JSwambo commented Dec 17, 2021

Okay after further digging I think we do! I believe we should create the replacement Cancel Transaction with new inputs, then use walletprocesspsbt

@darosior
Copy link
Member Author

Why? As previously discussed, using a bitcoind wallet presents some drawbacks and i'd like to avoid it as much as possible.
For your interest and if walletprocesspsbt was the reason why you wanted a bitcoind wallet, "processing" a PSBT is the main purpose of revault_tx...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants