diff --git a/brush-core/src/builtins.rs b/brush-core/src/builtins.rs index ffc7c97f..7ba09126 100644 --- a/brush-core/src/builtins.rs +++ b/brush-core/src/builtins.rs @@ -396,8 +396,7 @@ fn brush_help_styles() -> clap::builder::Styles { /// # Returns /// /// * a parsed struct T from [`clap::Parser::parse_from`] -/// * the remain iterator `args` with `--` and the rest arguments if they present -/// othervise None +/// * the remain iterator `args` with `--` and the rest arguments if they present othervise None /// /// # Examples /// ``` @@ -421,8 +420,8 @@ where S: Into + Clone + PartialEq<&'static str>, { let mut args = args.into_iter(); - // the best way to save `--` is to get it out with a side effect while `clap` iterates over the args - // this way we can be 100% sure that we have '--' and the remaining args + // the best way to save `--` is to get it out with a side effect while `clap` iterates over the + // args this way we can be 100% sure that we have '--' and the remaining args // and we will iterate only once let mut hyphen = None; let args_before_hyphen = args.by_ref().take_while(|a| { @@ -438,7 +437,8 @@ where } /// Similar to [`parse_known`] but with [`clap::Parser::try_parse_from`] -/// This function is used to parse arguments in builtins such as [`crate::builtins::echo::EchoCommand`] +/// This function is used to parse arguments in builtins such as +/// [`crate::builtins::echo::EchoCommand`] pub fn try_parse_known( args: impl IntoIterator, ) -> Result<(T, Option>), clap::Error> { diff --git a/brush-core/src/builtins/alias.rs b/brush-core/src/builtins/alias.rs index 99177ff3..7b9f7c25 100644 --- a/brush-core/src/builtins/alias.rs +++ b/brush-core/src/builtins/alias.rs @@ -15,7 +15,6 @@ pub(crate) struct AliasCommand { aliases: Vec, } - impl builtins::Command for AliasCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/bg.rs b/brush-core/src/builtins/bg.rs index 98d7d7bd..7faca92b 100644 --- a/brush-core/src/builtins/bg.rs +++ b/brush-core/src/builtins/bg.rs @@ -10,7 +10,6 @@ pub(crate) struct BgCommand { job_specs: Vec, } - impl builtins::Command for BgCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/break_.rs b/brush-core/src/builtins/break_.rs index 83cdbf1e..246c15b2 100644 --- a/brush-core/src/builtins/break_.rs +++ b/brush-core/src/builtins/break_.rs @@ -10,7 +10,6 @@ pub(crate) struct BreakCommand { which_loop: i8, } - impl builtins::Command for BreakCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/brushinfo.rs b/brush-core/src/builtins/brushinfo.rs index d7d8a9d8..9db907c0 100644 --- a/brush-core/src/builtins/brushinfo.rs +++ b/brush-core/src/builtins/brushinfo.rs @@ -53,7 +53,6 @@ enum CompleteCommand { }, } - impl builtins::Command for BrushInfoCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/builtin_.rs b/brush-core/src/builtins/builtin_.rs index be522627..a6fbd425 100644 --- a/brush-core/src/builtins/builtin_.rs +++ b/brush-core/src/builtins/builtin_.rs @@ -14,7 +14,6 @@ pub(crate) struct BuiltinCommand { args: Vec, } - impl builtins::Command for BuiltinCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/cd.rs b/brush-core/src/builtins/cd.rs index b505f5c9..63a67d98 100644 --- a/brush-core/src/builtins/cd.rs +++ b/brush-core/src/builtins/cd.rs @@ -28,7 +28,6 @@ pub(crate) struct CdCommand { target_dir: Option, } - impl builtins::Command for CdCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/colon.rs b/brush-core/src/builtins/colon.rs index 85662e4a..371d1ed0 100644 --- a/brush-core/src/builtins/colon.rs +++ b/brush-core/src/builtins/colon.rs @@ -10,7 +10,6 @@ pub(crate) struct ColonCommand { args: Vec, } - impl builtins::Command for ColonCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/command.rs b/brush-core/src/builtins/command.rs index 990445e0..eb6ed8b6 100644 --- a/brush-core/src/builtins/command.rs +++ b/brush-core/src/builtins/command.rs @@ -26,7 +26,6 @@ pub(crate) struct CommandCommand { args: Vec, } - impl builtins::Command for CommandCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/complete.rs b/brush-core/src/builtins/complete.rs index 1fca5b45..dcbf23cd 100644 --- a/brush-core/src/builtins/complete.rs +++ b/brush-core/src/builtins/complete.rs @@ -210,7 +210,6 @@ pub(crate) struct CompleteCommand { names: Vec, } - impl builtins::Command for CompleteCommand { async fn execute( &self, @@ -435,7 +434,6 @@ pub(crate) struct CompGenCommand { word: Option, } - impl builtins::Command for CompGenCommand { async fn execute( &self, @@ -514,7 +512,6 @@ pub(crate) struct CompOptCommand { names: Vec, } - impl builtins::Command for CompOptCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/continue_.rs b/brush-core/src/builtins/continue_.rs index 673d0c36..79631189 100644 --- a/brush-core/src/builtins/continue_.rs +++ b/brush-core/src/builtins/continue_.rs @@ -10,7 +10,6 @@ pub(crate) struct ContinueCommand { which_loop: i8, } - impl builtins::Command for ContinueCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/dirs.rs b/brush-core/src/builtins/dirs.rs index 4e871263..9024f72c 100644 --- a/brush-core/src/builtins/dirs.rs +++ b/brush-core/src/builtins/dirs.rs @@ -25,7 +25,6 @@ pub(crate) struct DirsCommand { // TODO: implement +N and -N } - impl builtins::Command for DirsCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/dot.rs b/brush-core/src/builtins/dot.rs index 2069ab34..34b0dac2 100644 --- a/brush-core/src/builtins/dot.rs +++ b/brush-core/src/builtins/dot.rs @@ -15,7 +15,6 @@ pub(crate) struct DotCommand { pub script_args: Vec, } - impl builtins::Command for DotCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/echo.rs b/brush-core/src/builtins/echo.rs index a98a2fbd..a4df5b7d 100644 --- a/brush-core/src/builtins/echo.rs +++ b/brush-core/src/builtins/echo.rs @@ -24,10 +24,9 @@ pub(crate) struct EchoCommand { args: Vec, } - impl builtins::Command for EchoCommand { - /// Override the default [builtins::Command::new] function to handle clap's limitation related to `--`. - /// See [crate::builtins::parse_known] for more information + /// Override the default [builtins::Command::new] function to handle clap's limitation related + /// to `--`. See [crate::builtins::parse_known] for more information /// TODO: we can safely remove this after the issue is resolved fn new(args: I) -> Result where diff --git a/brush-core/src/builtins/enable.rs b/brush-core/src/builtins/enable.rs index ada10a47..6bc0da63 100644 --- a/brush-core/src/builtins/enable.rs +++ b/brush-core/src/builtins/enable.rs @@ -37,7 +37,6 @@ pub(crate) struct EnableCommand { names: Vec, } - impl builtins::Command for EnableCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/eval.rs b/brush-core/src/builtins/eval.rs index fc653dac..c970a323 100644 --- a/brush-core/src/builtins/eval.rs +++ b/brush-core/src/builtins/eval.rs @@ -9,7 +9,6 @@ pub(crate) struct EvalCommand { pub args: Vec, } - impl builtins::Command for EvalCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/exec.rs b/brush-core/src/builtins/exec.rs index e9ca0b81..0137e99d 100644 --- a/brush-core/src/builtins/exec.rs +++ b/brush-core/src/builtins/exec.rs @@ -23,7 +23,6 @@ pub(crate) struct ExecCommand { args: Vec, } - impl builtins::Command for ExecCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/exit.rs b/brush-core/src/builtins/exit.rs index 58b853b6..9c5b9d02 100644 --- a/brush-core/src/builtins/exit.rs +++ b/brush-core/src/builtins/exit.rs @@ -9,7 +9,6 @@ pub(crate) struct ExitCommand { code: Option, } - impl builtins::Command for ExitCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/export.rs b/brush-core/src/builtins/export.rs index 2211a619..19541f4a 100644 --- a/brush-core/src/builtins/export.rs +++ b/brush-core/src/builtins/export.rs @@ -37,7 +37,6 @@ impl builtins::DeclarationCommand for ExportCommand { } } - impl builtins::Command for ExportCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/false_.rs b/brush-core/src/builtins/false_.rs index 73bdbdee..a2be7aa3 100644 --- a/brush-core/src/builtins/false_.rs +++ b/brush-core/src/builtins/false_.rs @@ -6,7 +6,6 @@ use crate::{builtins, commands}; #[derive(Parser)] pub(crate) struct FalseCommand {} - impl builtins::Command for FalseCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/fg.rs b/brush-core/src/builtins/fg.rs index 6fedd30a..231d38c8 100644 --- a/brush-core/src/builtins/fg.rs +++ b/brush-core/src/builtins/fg.rs @@ -10,7 +10,6 @@ pub(crate) struct FgCommand { job_spec: Option, } - impl builtins::Command for FgCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/getopts.rs b/brush-core/src/builtins/getopts.rs index 9beaca4a..3d971604 100644 --- a/brush-core/src/builtins/getopts.rs +++ b/brush-core/src/builtins/getopts.rs @@ -18,7 +18,6 @@ pub(crate) struct GetOptsCommand { args: Vec, } - impl builtins::Command for GetOptsCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/help.rs b/brush-core/src/builtins/help.rs index 93fb2b6c..32d0fdef 100644 --- a/brush-core/src/builtins/help.rs +++ b/brush-core/src/builtins/help.rs @@ -22,7 +22,6 @@ pub(crate) struct HelpCommand { topic_patterns: Vec, } - impl builtins::Command for HelpCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/jobs.rs b/brush-core/src/builtins/jobs.rs index da25fd9a..b0ef597c 100644 --- a/brush-core/src/builtins/jobs.rs +++ b/brush-core/src/builtins/jobs.rs @@ -31,7 +31,6 @@ pub(crate) struct JobsCommand { job_specs: Vec, } - impl builtins::Command for JobsCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/kill.rs b/brush-core/src/builtins/kill.rs index d4f0883c..61887102 100644 --- a/brush-core/src/builtins/kill.rs +++ b/brush-core/src/builtins/kill.rs @@ -16,7 +16,6 @@ pub(crate) struct KillCommand { // // TODO: implement -sigspec syntax - // /// List known signal names. #[arg(short = 'l', short_alias = 'L')] list_signals: bool, @@ -25,7 +24,6 @@ pub(crate) struct KillCommand { args: Vec, } - impl builtins::Command for KillCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/let_.rs b/brush-core/src/builtins/let_.rs index 9ac8f682..9f2cb4ae 100644 --- a/brush-core/src/builtins/let_.rs +++ b/brush-core/src/builtins/let_.rs @@ -11,7 +11,6 @@ pub(crate) struct LetCommand { exprs: Vec, } - impl builtins::Command for LetCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/popd.rs b/brush-core/src/builtins/popd.rs index fc7daf58..d525febe 100644 --- a/brush-core/src/builtins/popd.rs +++ b/brush-core/src/builtins/popd.rs @@ -11,10 +11,8 @@ pub(crate) struct PopdCommand { no_directory_change: bool, // // TODO: implement +N and -N - // } - impl builtins::Command for PopdCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/printf.rs b/brush-core/src/builtins/printf.rs index 5cad9a90..a5390999 100644 --- a/brush-core/src/builtins/printf.rs +++ b/brush-core/src/builtins/printf.rs @@ -16,7 +16,6 @@ pub(crate) struct PrintfCommand { format_and_args: Vec, } - impl builtins::Command for PrintfCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/pushd.rs b/brush-core/src/builtins/pushd.rs index 69beeb9d..595dedd6 100644 --- a/brush-core/src/builtins/pushd.rs +++ b/brush-core/src/builtins/pushd.rs @@ -13,10 +13,8 @@ pub(crate) struct PushdCommand { dir: String, // // TODO: implement +N and -N - // } - impl builtins::Command for PushdCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/pwd.rs b/brush-core/src/builtins/pwd.rs index c3ad8f9f..8ad06db9 100644 --- a/brush-core/src/builtins/pwd.rs +++ b/brush-core/src/builtins/pwd.rs @@ -14,7 +14,6 @@ pub(crate) struct PwdCommand { allow_symlinks: bool, } - impl builtins::Command for PwdCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/read.rs b/brush-core/src/builtins/read.rs index 05484dbd..ab70f84e 100644 --- a/brush-core/src/builtins/read.rs +++ b/brush-core/src/builtins/read.rs @@ -59,7 +59,6 @@ pub(crate) struct ReadCommand { variable_names: Vec, } - impl builtins::Command for ReadCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/return_.rs b/brush-core/src/builtins/return_.rs index 7483e5d8..f52e3d45 100644 --- a/brush-core/src/builtins/return_.rs +++ b/brush-core/src/builtins/return_.rs @@ -9,7 +9,6 @@ pub(crate) struct ReturnCommand { code: Option, } - impl builtins::Command for ReturnCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/set.rs b/brush-core/src/builtins/set.rs index ce7b16e5..9fa64485 100644 --- a/brush-core/src/builtins/set.rs +++ b/brush-core/src/builtins/set.rs @@ -130,7 +130,6 @@ pub(crate) struct SetCommand { positional_args: Vec, } - impl builtins::Command for SetCommand { fn takes_plus_options() -> bool { true diff --git a/brush-core/src/builtins/shift.rs b/brush-core/src/builtins/shift.rs index f641ba06..df38628a 100644 --- a/brush-core/src/builtins/shift.rs +++ b/brush-core/src/builtins/shift.rs @@ -9,7 +9,6 @@ pub(crate) struct ShiftCommand { n: Option, } - impl builtins::Command for ShiftCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/shopt.rs b/brush-core/src/builtins/shopt.rs index cd78faa5..d1604b2e 100644 --- a/brush-core/src/builtins/shopt.rs +++ b/brush-core/src/builtins/shopt.rs @@ -31,7 +31,6 @@ pub(crate) struct ShoptCommand { options: Vec, } - impl builtins::Command for ShoptCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/test.rs b/brush-core/src/builtins/test.rs index 1f238a4b..532552c5 100644 --- a/brush-core/src/builtins/test.rs +++ b/brush-core/src/builtins/test.rs @@ -11,7 +11,6 @@ pub(crate) struct TestCommand { args: Vec, } - impl builtins::Command for TestCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/trap.rs b/brush-core/src/builtins/trap.rs index 768c35b8..1a9cc71f 100644 --- a/brush-core/src/builtins/trap.rs +++ b/brush-core/src/builtins/trap.rs @@ -17,7 +17,6 @@ pub(crate) struct TrapCommand { args: Vec, } - impl builtins::Command for TrapCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/true_.rs b/brush-core/src/builtins/true_.rs index fb4be607..c70c34c9 100644 --- a/brush-core/src/builtins/true_.rs +++ b/brush-core/src/builtins/true_.rs @@ -6,7 +6,6 @@ use crate::{builtins, commands}; #[derive(Parser)] pub(crate) struct TrueCommand {} - impl builtins::Command for TrueCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/type_.rs b/brush-core/src/builtins/type_.rs index 7d30b853..87239811 100644 --- a/brush-core/src/builtins/type_.rs +++ b/brush-core/src/builtins/type_.rs @@ -44,7 +44,6 @@ enum ResolvedType { File(PathBuf), } - impl builtins::Command for TypeCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/umask.rs b/brush-core/src/builtins/umask.rs index 83cee0d1..8a2ce743 100644 --- a/brush-core/src/builtins/umask.rs +++ b/brush-core/src/builtins/umask.rs @@ -20,7 +20,6 @@ pub(crate) struct UmaskCommand { mode: Option, } - impl builtins::Command for UmaskCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/unalias.rs b/brush-core/src/builtins/unalias.rs index 16aeb7f2..50992a91 100644 --- a/brush-core/src/builtins/unalias.rs +++ b/brush-core/src/builtins/unalias.rs @@ -14,7 +14,6 @@ pub(crate) struct UnaliasCommand { aliases: Vec, } - impl builtins::Command for UnaliasCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/unimp.rs b/brush-core/src/builtins/unimp.rs index 3ffb2226..db60c69c 100644 --- a/brush-core/src/builtins/unimp.rs +++ b/brush-core/src/builtins/unimp.rs @@ -13,7 +13,6 @@ pub(crate) struct UnimplementedCommand { declarations: Vec, } - impl builtins::Command for UnimplementedCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/unset.rs b/brush-core/src/builtins/unset.rs index cc0fcd8b..94ac0052 100644 --- a/brush-core/src/builtins/unset.rs +++ b/brush-core/src/builtins/unset.rs @@ -34,7 +34,6 @@ impl UnsetNameInterpretation { } } - impl builtins::Command for UnsetCommand { async fn execute( &self, diff --git a/brush-core/src/builtins/wait.rs b/brush-core/src/builtins/wait.rs index fa254a42..c8dbf0b1 100644 --- a/brush-core/src/builtins/wait.rs +++ b/brush-core/src/builtins/wait.rs @@ -22,7 +22,6 @@ pub(crate) struct WaitCommand { job_specs: Vec, } - impl builtins::Command for WaitCommand { async fn execute( &self, diff --git a/brush-core/src/completion.rs b/brush-core/src/completion.rs index d90cca1d..a989c621 100644 --- a/brush-core/src/completion.rs +++ b/brush-core/src/completion.rs @@ -777,6 +777,9 @@ impl Config { // preceding token may be. preceding_token = Some(token); } + // else { + // tracing::debug!(target: trace_categories::COMPLETION, "failed to tokenize input + // line"); // If the position is after the last token, then we need to insert an empty // token for the new token to be generated. diff --git a/brush-core/src/error.rs b/brush-core/src/error.rs index dcbce45f..a99c25d3 100644 --- a/brush-core/src/error.rs +++ b/brush-core/src/error.rs @@ -190,4 +190,3 @@ pub enum Error { pub(crate) fn unimp(msg: &'static str) -> Result { Err(Error::Unimplemented(msg)) } - diff --git a/brush-core/src/variables.rs b/brush-core/src/variables.rs index ec3848ff..1d5470c3 100644 --- a/brush-core/src/variables.rs +++ b/brush-core/src/variables.rs @@ -215,8 +215,8 @@ impl ShellVariable { if append { match (&self.value, &value) { - // If we're appending an array to a declared-but-unset variable (or appending anything to a declared-but-unset array), - // then fill it out first. + // If we're appending an array to a declared-but-unset variable (or appending + // anything to a declared-but-unset array), then fill it out first. (ShellValue::Unset(_), ShellValueLiteral::Array(_)) | ( ShellValue::Unset( @@ -226,8 +226,8 @@ impl ShellVariable { ) => { self.assign(ShellValueLiteral::Array(ArrayLiteral(vec![])), false)?; } - // If we're trying to append an array to a string, we first promote the string to be an array - // with the string being present at index 0. + // If we're trying to append an array to a string, we first promote the string to be + // an array with the string being present at index 0. (ShellValue::String(_), ShellValueLiteral::Array(_)) => { self.convert_to_indexed_array()?; } @@ -289,9 +289,9 @@ impl ShellVariable { ShellValueLiteral::Scalar(s), ) => self.assign_at_index(String::from("0"), s, false), - // If we're updating an indexed array value with an array, then preserve the array type. - // We also default to using an indexed array if we are assigning an array to a previously - // string-holding variable. + // If we're updating an indexed array value with an array, then preserve the array + // type. We also default to using an indexed array if we are + // assigning an array to a previously string-holding variable. ( ShellValue::IndexedArray(_) | ShellValue::Unset( @@ -305,7 +305,8 @@ impl ShellVariable { Ok(()) } - // If we're updating an associative array value with an array, then preserve the array type. + // If we're updating an associative array value with an array, then preserve the + // array type. ( ShellValue::AssociativeArray(_) | ShellValue::Unset(ShellValueUnsetType::AssociativeArray), @@ -334,7 +335,8 @@ impl ShellVariable { /// /// * `array_index` - The index at which to assign the value. /// * `value` - The value to assign to the variable at the given index. - /// * `append` - Whether or not to append the value to the preexisting value stored at the given index. + /// * `append` - Whether or not to append the value to the preexisting value stored at the given + /// index. #[allow(clippy::needless_pass_by_value)] pub fn assign_at_index( &mut self, diff --git a/brush-interactive/src/interactive_shell.rs b/brush-interactive/src/interactive_shell.rs index 84b0c7db..914c09a4 100644 --- a/brush-interactive/src/interactive_shell.rs +++ b/brush-interactive/src/interactive_shell.rs @@ -53,7 +53,8 @@ pub trait InteractiveShell { /// Runs the interactive shell loop, reading commands from standard input and writing /// results to standard output and standard error. Continues until the shell /// normally exits or until a fatal error occurs. - // NOTE: we use desugared async here because [async_fn_in_trait] "warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified" + // NOTE: we use desugared async here because [async_fn_in_trait] "warning: use of `async fn` in + // public traits is discouraged as auto trait bounds cannot be specified" fn run_interactively(&mut self) -> impl std::future::Future> { async { // TODO: Consider finding a better place for this. diff --git a/brush-interactive/src/reedline/highlighter.rs b/brush-interactive/src/reedline/highlighter.rs index 5f9036f9..6b2f04d9 100644 --- a/brush-interactive/src/reedline/highlighter.rs +++ b/brush-interactive/src/reedline/highlighter.rs @@ -244,7 +244,8 @@ impl<'a> StyledInputLine<'a> { } fn skip_ahead(&mut self, dest: usize) { - // Append a no-op style to make sure we cover any trailing gaps in the input line not otherwise styled. + // Append a no-op style to make sure we cover any trailing gaps in the input line not + // otherwise styled. self.append_style(Style::new(), dest, dest); } diff --git a/brush-shell/src/brushctl.rs b/brush-shell/src/brushctl.rs index e03fc9ee..07627d98 100644 --- a/brush-shell/src/brushctl.rs +++ b/brush-shell/src/brushctl.rs @@ -42,7 +42,6 @@ enum EventsCommand { }, } - impl brush_core::builtins::Command for BrushCtlCommand { async fn execute( &self, @@ -54,7 +53,6 @@ impl brush_core::builtins::Command for BrushCtlCommand { } } - impl EventsCommand { fn execute( &self, diff --git a/brush-shell/src/shell_factory.rs b/brush-shell/src/shell_factory.rs index e5c034c7..58d70c04 100644 --- a/brush-shell/src/shell_factory.rs +++ b/brush-shell/src/shell_factory.rs @@ -1,4 +1,3 @@ - pub(crate) trait ShellFactory { type ShellType: brush_interactive::InteractiveShell + Send; @@ -53,7 +52,6 @@ impl AsMut for StubShell { pub(crate) struct RustylineShellFactory; - impl ShellFactory for RustylineShellFactory { #[cfg(all(feature = "rustyline", any(windows, unix)))] type ShellType = brush_interactive::RustylineShell; @@ -78,7 +76,6 @@ impl ShellFactory for RustylineShellFactory { pub(crate) struct ReedlineShellFactory; - impl ShellFactory for ReedlineShellFactory { #[cfg(all(feature = "reedline", any(windows, unix)))] type ShellType = brush_interactive::ReedlineShell; @@ -103,7 +100,6 @@ impl ShellFactory for ReedlineShellFactory { pub(crate) struct BasicShellFactory; - impl ShellFactory for BasicShellFactory { #[cfg(feature = "basic")] type ShellType = brush_interactive::BasicShell;