Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate "note" is not correctly commented out in biblatex output #3040

Open
ryofurue opened this issue Oct 29, 2024 · 8 comments
Open

Duplicate "note" is not correctly commented out in biblatex output #3040

ryofurue opened this issue Oct 29, 2024 · 8 comments

Comments

@ryofurue
Copy link

Debug log ID

3ZW88UUZ-apse/6.7.248-6

What happened?

I have a note
TEOS-10 homepage is http://www.teos-10.org/index.htm

written by me and attached to an entry. The entry also has a string "OCLC: 724024071" in the Extra field, which was inserted there by the Zotero browser plugin.

The biblatex output then includes this extra info

% == BibLateX quality report for McDougallTJ.BarkerPM:2011:
% duplicate "note" ("<div data-schema-version="8"><p>TEOS-10 homepage is <a href="http://www.teos-10.org/index.htm" rel="noopener noreferrer nofollow">http://www.teos-10.org/index.htm</a></p>
</div>") ignored
% ? unused Library catalog ("Open WorldCat")

Note that there is a linebreak between</p> and </div>. As a result, the piece of text </div>") ignored is not commented out and biber complains

WARN - BibTeX subsystem: /var/folders/vq/54_v0z752kv_2ptqsy1vxbrw0000gn/T/biber_tmp_tfQf/68a3e86a5eef43cd0fa2ad5ac320682f_4880.utf8, line 14557, warning: 15 characters of junk seen at toplevel
@retorquere
Copy link
Owner

Can you get me a debug log by right-clicking that item and sending the log from the popup menu?

@ryofurue
Copy link
Author

ryofurue commented Nov 1, 2024

Can you get me a debug log by right-clicking that item and sending the log from the popup menu?

ACBSRIYI-refs-apse/6.7.248-6

I've modify the entry somewhat but the problem is the same:

@book{McDougallTJ.Barker-delete-me,
  title = {Getting started with {{TEOS-10}} and the {{Gibbs Seawater}} ({{GSW}}) {{Oceanographic Toolbox}}},
  author = {McDougall, Trevor J and Barker, Paul M},
  date = {2011},
  publisher = {Trevor J McDougall},
  location = {Battery Point, Tasmania, Australia},
  url = {https://www.teos-10.org/pubs/Getting_Started.pdf},
  isbn = {978-0-646-55621-5},
  language = {English},
  annotation = {OCLC: 724024071},
  note = {OCLC: 724024071}
}
% == BibLateX quality report for McDougallTJ.Barker-delete-me:
% duplicate "note" ("<div data-schema-version="8"><p>http://www.teos-10.org/index.htm</p>
</div>") ignored
% ? unused Library catalog ("Open WorldCat")

</div>") ignored is printed after the newline.

@retorquere
Copy link
Owner

I cannot reproduce the problem with ACBSRIYI-refs-apse/6.7.248-6. <div data-schema-version="8"> also does not appear in it anywhere.

@retorquere
Copy link
Owner

I think I have a fix but without a testcase I can't prevent regressions later

retorquere added a commit that referenced this issue Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

🤖 this is your friendly neighborhood build bot announcing test build 6.7.248.7247 ("cleanup")

This update may name other issues, but the build just dropped here is for you; it just means problems already fixed in other issues have been folded into the work we are doing here. Install in Zotero by downloading test build 6.7.248.7247, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

@ryofurue
Copy link
Author

ryofurue commented Nov 2, 2024

The test build fixed the problem. Thank you!!! The following is the current biblatex database generated by BBT:

% . . .
@book{McDougallTJ.Barker-delete-me,
  title = {Getting started with {{TEOS-10}} and the {{Gibbs Seawater}} ({{GSW}}) {{Oceanographic Toolbox}}},
  author = {McDougall, Trevor J and Barker, Paul M},
  date = {2011},
  publisher = {Trevor J McDougall},
  location = {Battery Point, Tasmania, Australia},
  url = {https://www.teos-10.org/pubs/Getting_Started.pdf},
  isbn = {978-0-646-55621-5},
  language = {English},
  annotation = {OCLC: 724024071},
  note = {OCLC: 724024071}
}
% == BibLateX quality report for McDougallTJ.Barker-delete-me:
% duplicate "note" ("<div data-schema-version="8"><p>http://www.teos-10.org/index.htm</p> </div>") ignored
% ? unused Library catalog ("Open WorldCat")
% . . .

The HTML code <div data-schema-version="8" . . . must be from the "note" I attached to the entry. I just wrote "http://www.teos-10.org/index.htm" there.

@retorquere
Copy link
Owner

Yeah I know but I'd prefer to have the actual case in my test suite. The log you sent doesn't have the note that caused the problem so I have no test case to prevent regression.

@retorquere
Copy link
Owner

I have not been able to reproduce the problem. Can you please send a debug from an item where you could reproduce the problem, and make sure to check the "notes" checkbox in the debug log. I don't really want to release code for which I can't reproduce the behavior it was supposed to address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants