Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"bsconfig.json" hardcoded in error messages #7118

Open
cknitt opened this issue Oct 22, 2024 · 1 comment
Open

"bsconfig.json" hardcoded in error messages #7118

cknitt opened this issue Oct 22, 2024 · 1 comment
Labels
Milestone

Comments

@cknitt
Copy link
Member

cknitt commented Oct 22, 2024

Even if the user has a rescript.json, error messages are still talking about bsconfig.json:

https://github.com/rescript-lang/rescript-compiler/blob/4c28fa1ce386f694d7ca83f351d4ff1bb6fe6f30/compiler/bsb/bsb_exception.ml#L63

@cknitt cknitt added the bug label Oct 22, 2024
@cknitt cknitt added this to the v12 milestone Oct 22, 2024
@fhammerschmidt
Copy link
Member

fhammerschmidt commented Oct 23, 2024

Should be a clickable link, especially if you are in a monorepo with multiple rescript.json files.
So rather show the full path as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants