Fix #24: Support for Js.Date.t #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davesnx
reviewed
Mar 7, 2021
| let date = | ||
| Js.Json.decodeString(j)->Belt.Option.getExn->Js.Date.fromString; | ||
| if (Js.Float.isNaN(Js.Date.getTime(date))) { | ||
| failwith("NaN"); |
There was a problem hiding this comment.
This should be Belt.Result.Error instead, using Result would make the error propagate to the parent and won't crash at runtime.
|
Hi @davesnx, thanks a lot for the review! Unfortunately I'm not working with ReasonML anymore and I forgot about this 😅 I'm closing the PR, but please feel free to take it over if the code is still useful. |
|
Hey @alfonsogarciacaro, no worries the code is still useful for sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #24. I'm using
Js.Date.toJSONUnsafefor encoding following bs-json but please let me know if you prefer to usetoISOStringinstead.Thanks a lot for the ppx!