From bcb25bb401de8b7cb9f809f75e4294ace880172f Mon Sep 17 00:00:00 2001 From: Antoine Beyeler Date: Tue, 12 Nov 2024 09:06:13 +0100 Subject: [PATCH] Add missing screenshot to `GeoLineStrings` docs --- .../definitions/rerun/archetypes/geo_line_strings.fbs | 3 +-- .../re_types/definitions/rerun/archetypes/geo_points.fbs | 1 - crates/store/re_types/src/archetypes/geo_line_strings.rs | 9 +++++++++ .../reference/types/archetypes/geo_line_strings.md | 8 ++++++++ rerun_cpp/src/rerun/archetypes/geo_line_strings.hpp | 2 ++ rerun_py/rerun_sdk/rerun/archetypes/geo_line_strings.py | 9 +++++++++ 6 files changed, 29 insertions(+), 3 deletions(-) diff --git a/crates/store/re_types/definitions/rerun/archetypes/geo_line_strings.fbs b/crates/store/re_types/definitions/rerun/archetypes/geo_line_strings.fbs index 70d8ee2d35d4..f1ad79cc1c12 100644 --- a/crates/store/re_types/definitions/rerun/archetypes/geo_line_strings.fbs +++ b/crates/store/re_types/definitions/rerun/archetypes/geo_line_strings.fbs @@ -8,8 +8,7 @@ namespace rerun.archetypes; /// /// **Note**: Geospatial entities are experimental. /// -/// \example archetypes/geo_line_string_simple title="Log a geospatial line string" -// TODO(ab): add screenshot +/// \example archetypes/geo_line_string_simple title="Log a geospatial line string" image="https://static.rerun.io/geo_line_strings_simple/5669983eb10906ace303755b5b5039cad75b917f/1200w.png" table GeoLineStrings ( "attr.rust.derive": "PartialEq", "attr.rust.new_pub_crate", diff --git a/crates/store/re_types/definitions/rerun/archetypes/geo_points.fbs b/crates/store/re_types/definitions/rerun/archetypes/geo_points.fbs index 198e8267614f..a21581427e17 100644 --- a/crates/store/re_types/definitions/rerun/archetypes/geo_points.fbs +++ b/crates/store/re_types/definitions/rerun/archetypes/geo_points.fbs @@ -5,7 +5,6 @@ namespace rerun.archetypes; /// **Note**: Geospatial entities are experimental. /// /// \example archetypes/geo_point_simple title="Log a geospatial point" image="https://static.rerun.io/geopoint_simple/146b0783c5aea1c1b6a9aab938879942b7c820e2/1200w.png" -// TODO(ab): screenshot table GeoPoints ( "attr.rust.derive": "PartialEq", "attr.rust.new_pub_crate", diff --git a/crates/store/re_types/src/archetypes/geo_line_strings.rs b/crates/store/re_types/src/archetypes/geo_line_strings.rs index 69b248278cb9..73dd93f9f7c0 100644 --- a/crates/store/re_types/src/archetypes/geo_line_strings.rs +++ b/crates/store/re_types/src/archetypes/geo_line_strings.rs @@ -47,6 +47,15 @@ use ::re_types_core::{DeserializationError, DeserializationResult}; /// Ok(()) /// } /// ``` +///
+/// +/// +/// +/// +/// +/// +/// +///
#[derive(Clone, Debug, PartialEq)] pub struct GeoLineStrings { /// The line strings, expressed in [EPSG:4326](https://epsg.io/4326) coordinates (North/East-positive degrees). diff --git a/docs/content/reference/types/archetypes/geo_line_strings.md b/docs/content/reference/types/archetypes/geo_line_strings.md index ae59ddcb6787..a1361e6260bb 100644 --- a/docs/content/reference/types/archetypes/geo_line_strings.md +++ b/docs/content/reference/types/archetypes/geo_line_strings.md @@ -30,3 +30,11 @@ Also known as "line strips" or "polylines". snippet: archetypes/geo_line_string_simple + + + + + + + + diff --git a/rerun_cpp/src/rerun/archetypes/geo_line_strings.hpp b/rerun_cpp/src/rerun/archetypes/geo_line_strings.hpp index 16748341f357..29c65f1f769e 100644 --- a/rerun_cpp/src/rerun/archetypes/geo_line_strings.hpp +++ b/rerun_cpp/src/rerun/archetypes/geo_line_strings.hpp @@ -27,6 +27,8 @@ namespace rerun::archetypes { /// ## Example /// /// ### Log a geospatial line string + /// ![image](https://static.rerun.io/geo_line_strings_simple/5669983eb10906ace303755b5b5039cad75b917f/full.png) + /// /// ```cpp /// #include /// diff --git a/rerun_py/rerun_sdk/rerun/archetypes/geo_line_strings.py b/rerun_py/rerun_sdk/rerun/archetypes/geo_line_strings.py index 00092fd548b1..14432946db97 100644 --- a/rerun_py/rerun_sdk/rerun/archetypes/geo_line_strings.py +++ b/rerun_py/rerun_sdk/rerun/archetypes/geo_line_strings.py @@ -48,6 +48,15 @@ class GeoLineStrings(GeoLineStringsExt, Archetype): ), ) ``` +
+ + + + + + + +
"""