From b9868319e654ff0cfb6b5549895c41947091b4ef Mon Sep 17 00:00:00 2001 From: Andreas Reich Date: Mon, 14 Oct 2024 09:59:26 +0200 Subject: [PATCH 1/2] fix links --- crates/store/re_dataframe/README.md | 2 +- .../re_types/definitions/rerun/components/value_range.fbs | 1 + crates/store/re_types/src/image.rs | 2 +- .../src/resource_managers/image_data_to_texture.rs | 2 +- docs/content/reference/types/components/value_range.md | 6 +++--- docs/content/reference/types/datatypes/range1d.md | 2 +- lychee.toml | 3 ++- 7 files changed, 10 insertions(+), 8 deletions(-) diff --git a/crates/store/re_dataframe/README.md b/crates/store/re_dataframe/README.md index 6383cd9130de..a408cb889a24 100644 --- a/crates/store/re_dataframe/README.md +++ b/crates/store/re_dataframe/README.md @@ -3,7 +3,7 @@ Part of the [`rerun`](https://github.com/rerun-io/rerun) family of crates. [![Latest version](https://img.shields.io/crates/v/re_dataframe.svg)](https://crates.io/crates/re_dataframe) -[![Documentation](https://docs.rs/re_dataframe/badge.svg)](https://docs.rs/re_dataframe) +[![Documentation](https://docs.rs/re_dataframe/badge.svg)](https://docs.rs/re_dataframe?speculative-link) ![MIT](https://img.shields.io/badge/license-MIT-blue.svg) ![Apache](https://img.shields.io/badge/license-Apache-blue.svg) diff --git a/crates/store/re_types/definitions/rerun/components/value_range.fbs b/crates/store/re_types/definitions/rerun/components/value_range.fbs index b238f2be856a..c2cf25d6a654 100644 --- a/crates/store/re_types/definitions/rerun/components/value_range.fbs +++ b/crates/store/re_types/definitions/rerun/components/value_range.fbs @@ -4,6 +4,7 @@ namespace rerun.components; /// Range of expected or valid values, specifying a lower and upper bound. struct ValueRange ( + "attr.docs.unreleased", "attr.rust.derive": "Copy, PartialEq, bytemuck::Pod, bytemuck::Zeroable", "attr.rust.repr": "transparent" ) { diff --git a/crates/store/re_types/src/image.rs b/crates/store/re_types/src/image.rs index a27b541492d2..ecafce9a959d 100644 --- a/crates/store/re_types/src/image.rs +++ b/crates/store/re_types/src/image.rs @@ -285,7 +285,7 @@ pub enum ColorPrimaries { /// These are the same primaries we usually assume and use for all of Rerun's rendering /// since they are the same primaries used by sRGB. /// - /// The OETF/EOTF function () is different, + /// The OETF/EOTF function () is different, /// but for all other purposes they are the same. /// (The only reason for us to convert to optical units ("linear" instead of "gamma") is for /// lighting computation & tonemapping where we typically start out with sRGB anyways!) diff --git a/crates/viewer/re_renderer/src/resource_managers/image_data_to_texture.rs b/crates/viewer/re_renderer/src/resource_managers/image_data_to_texture.rs index d0a2183887f1..b08de108fa0f 100644 --- a/crates/viewer/re_renderer/src/resource_managers/image_data_to_texture.rs +++ b/crates/viewer/re_renderer/src/resource_managers/image_data_to_texture.rs @@ -30,7 +30,7 @@ pub enum ColorPrimaries { /// These are the same primaries we usually assume and use for all our rendering /// since they are the same primaries used by sRGB. /// - /// The OETF/EOTF function () is different, + /// The OETF/EOTF function () is different, /// but for all other purposes they are the same. /// (The only reason for us to convert to optical units ("linear" instead of "gamma") is for /// lighting & tonemapping where we typically start out with an sRGB image!) diff --git a/docs/content/reference/types/components/value_range.md b/docs/content/reference/types/components/value_range.md index e13c0fc619a2..c97c589fdea3 100644 --- a/docs/content/reference/types/components/value_range.md +++ b/docs/content/reference/types/components/value_range.md @@ -10,9 +10,9 @@ Range of expected or valid values, specifying a lower and upper bound. * range: [`Range1D`](../datatypes/range1d.md) ## API reference links - * 🌊 [C++ API docs for `ValueRange`](https://ref.rerun.io/docs/cpp/stable/structrerun_1_1components_1_1ValueRange.html) - * 🐍 [Python API docs for `ValueRange`](https://ref.rerun.io/docs/python/stable/common/components#rerun.components.ValueRange) - * 🦀 [Rust API docs for `ValueRange`](https://docs.rs/rerun/latest/rerun/components/struct.ValueRange.html) + * 🌊 [C++ API docs for `ValueRange`](https://ref.rerun.io/docs/cpp/stable/structrerun_1_1components_1_1ValueRange.html?speculative-link) + * 🐍 [Python API docs for `ValueRange`](https://ref.rerun.io/docs/python/stable/common/components?speculative-link#rerun.components.ValueRange) + * 🦀 [Rust API docs for `ValueRange`](https://docs.rs/rerun/latest/rerun/components/struct.ValueRange.html?speculative-link) ## Used by diff --git a/docs/content/reference/types/datatypes/range1d.md b/docs/content/reference/types/datatypes/range1d.md index b485ac3f3cd1..352f6948881a 100644 --- a/docs/content/reference/types/datatypes/range1d.md +++ b/docs/content/reference/types/datatypes/range1d.md @@ -19,4 +19,4 @@ A 1D range, specifying a lower and upper bound. * [`Range1D`](../components/range1d.md) * [`Range2D`](../datatypes/range2d.md) -* [`ValueRange`](../components/value_range.md) +* [`ValueRange`](../components/value_range.md?speculative-link) diff --git a/lychee.toml b/lychee.toml index eaa68fe216bd..2265451aacb6 100644 --- a/lychee.toml +++ b/lychee.toml @@ -130,7 +130,8 @@ exclude = [ # Needs authentication 'https://edge.meilisearch.com', - 'https://eu.posthog.com/project/', # Requires to be logged in on PostHog. + 'https://eu.posthog.com/project/', # Requires to be logged in on PostHog. + 'https://github.com/rerun-io/internal-test-assets/\.*', # Temporarily down or not accessible. 'https://cs.nyu.edu/~silberman/datasets/nyu_depth_v2.html', # Nyud links are down every now and then. From 91f8e7dea06342e9723dd51ea68cbaf0c10b2fca Mon Sep 17 00:00:00 2001 From: Andreas Reich Date: Mon, 14 Oct 2024 10:26:22 +0200 Subject: [PATCH 2/2] use pixi environment for cargo test --- .github/workflows/reusable_checks_rust.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/reusable_checks_rust.yml b/.github/workflows/reusable_checks_rust.yml index 57dd6e587a1f..db1b60173f60 100644 --- a/.github/workflows/reusable_checks_rust.yml +++ b/.github/workflows/reusable_checks_rust.yml @@ -100,5 +100,10 @@ jobs: workload_identity_provider: ${{ secrets.GOOGLE_WORKLOAD_IDENTITY_PROVIDER }} service_account: ${{ secrets.GOOGLE_SERVICE_ACCOUNT }} - - name: cargo test --all-targets --all-features - run: cargo test --all-targets --all-features + # Building with `--all-features` requires extra build tools like `nasm`. + - uses: prefix-dev/setup-pixi@v0.8.1 + with: + pixi-version: v0.25.0 + + - name: pixi run cargo test --all-targets --all-features + run: pixi run cargo test --all-targets --all-features