Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port more of the viewer to arrow2 #8539

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

emilk
Copy link
Member

@emilk emilk commented Dec 19, 2024

Related

What

Port most of our viewer-facing code to arrow1

@emilk emilk added 🏹 arrow concerning arrow 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 19, 2024
Copy link

github-actions bot commented Dec 19, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
a6ba10b https://rerun.io/viewer/pr/8539 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk changed the base branch from main to emilk/arrow-fallbacks December 19, 2024 10:59
@emilk emilk changed the title Emilk/arrow port viewer Port more of the viewer to arrow2 Dec 19, 2024
@emilk
Copy link
Member Author

emilk commented Dec 19, 2024

@rerun-bot full-check

@emilk emilk marked this pull request as ready for review December 19, 2024 11:00
@emilk emilk added the do-not-merge Do not merge this PR label Dec 19, 2024
Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/12411355672

Base automatically changed from emilk/arrow-fallbacks to main December 19, 2024 13:21
@emilk emilk removed the do-not-merge Do not merge this PR label Dec 19, 2024
@emilk emilk force-pushed the emilk/arrow-port-viewer branch from d17a6aa to a6ba10b Compare December 19, 2024 13:22
@emilk emilk marked this pull request as draft December 19, 2024 13:23
@emilk
Copy link
Member Author

emilk commented Dec 19, 2024

DRAFT: I broke the dataframe view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏹 arrow concerning arrow exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant