Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorbet.semantic_family dropped from query results #8522

Open
jleibs opened this issue Dec 18, 2024 · 2 comments
Open

sorbet.semantic_family dropped from query results #8522

jleibs opened this issue Dec 18, 2024 · 2 comments
Labels
🪳 bug Something isn't working

Comments

@jleibs
Copy link
Member

jleibs commented Dec 18, 2024

This appears to be a consequence of:

This breaks the new send_dataframe functionality introduced in:

Code to repro:

from __future__ import annotations

import tempfile

import rerun as rr

with tempfile.TemporaryDirectory() as tmpdir:
    rrd = tmpdir + "/tmp.rrd"

    rr.init("rerun_example_test_recording")
    rr.set_time_seconds("my_index", 1)
    rr.log("points", rr.Points3D([1, 2, 3]))
    rr.save(rrd)

    recording = rr.dataframe.load_recording(rrd)
    assert recording is not None

df = recording.view(index="my_index", contents="points").select().read_all()
print(df.schema.field("/points:Position3D").metadata)

Prior to https://github.com/rerun-io/rerun/pull/8499/files

➜ python dump_tags.py 
{b'sorbet.path': b'/points', b'sorbet.logical_type': b'positions', b'sorbet.semantic_family': b'Points3D', b'sorbet.semantic_type': b'Position3D'}

After https://github.com/rerun-io/rerun/pull/8499/files

➜  python dump_tags.py 
{b'sorbet.path': b'/points', b'sorbet.semantic_type': b'Position3D'}
@jleibs jleibs added the 🪳 bug Something isn't working label Dec 18, 2024
@jleibs
Copy link
Member Author

jleibs commented Dec 18, 2024

I checked on the 0.19 / 0.20 releases.

Even though the code existed to set semantic_family:

archetype_name.map(|name| {
(
"sorbet.semantic_family".to_owned(),
name.short_name().to_owned(),
)
}),

This repro code shows it wasn't being set there either. We just didn't notice.

@jleibs
Copy link
Member Author

jleibs commented Dec 18, 2024

Can confirm this can be worked around by specifying include_indicator_columns = True on the view. This makes sense for a pre-tagged-component world.

teh-cmc pushed a commit that referenced this issue Dec 18, 2024
### Related
- #8522

### What
Explains how to avoid hitting an issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant