Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify handling of view hover/selections in a common place #8497

Open
grtlr opened this issue Dec 17, 2024 · 0 comments
Open

Unify handling of view hover/selections in a common place #8497

grtlr opened this issue Dec 17, 2024 · 0 comments
Labels
🚜 refactor Change the code, not the functionality ui concerns graphical user interface

Comments

@grtlr
Copy link
Contributor

grtlr commented Dec 17, 2024

Related

The PR above has some more information. There is also an internal discussion here: https://rerunio.slack.com/archives/C04MTSM2U91/p1734420075077489

What

From the PR above:

@Wumpf @abey79 I feel like the pattern repeats itself and it's easy to miss when writing new views. So I wonder if this could be unified. I see several options for this:

  • repurpose handle_select_hover_drag_interactions which only seems to be used for DataResult right now
  • Making each view return a Result<(Response, ViewSystemExecutionError> (instead of ()) and handling it outside of the view.
  • Creating a function analogous to handle_select_hover_drag_interactions.
@grtlr grtlr added ui concerns graphical user interface 🚜 refactor Change the code, not the functionality labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚜 refactor Change the code, not the functionality ui concerns graphical user interface
Projects
None yet
Development

No branches or pull requests

1 participant