Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug information from graph view selection panel #8496

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented Dec 17, 2024

What

Title.

This was a small part of @gavrelina's feedback.

@grtlr grtlr added the exclude from changelog PRs with this won't show up in CHANGELOG.md label Dec 17, 2024
Copy link

github-actions bot commented Dec 17, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
1c1bf0f https://rerun.io/viewer/pr/8496 +nightly +main

Note: This comment is updated whenever you push a commit.

@grtlr grtlr marked this pull request as draft December 17, 2024 09:14
@grtlr grtlr changed the title Build graph debug information only in debug builds Remove debug information from graph view selection panel Dec 17, 2024
@grtlr
Copy link
Contributor Author

grtlr commented Dec 17, 2024

I've decided to remove the debug information entirely, as I never needed anymore anyways. Note that we still have the bounding box as part of the selection panel.

@grtlr grtlr marked this pull request as ready for review December 17, 2024 09:24
@grtlr grtlr merged commit 7781de0 into main Dec 17, 2024
31 of 33 checks passed
@grtlr grtlr deleted the grtlr/graph-selection-ui branch December 17, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants