-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement level-of-detail on text labels #8450
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grtlr
added
the
exclude from changelog
PRs with this won't show up in CHANGELOG.md
label
Dec 13, 2024
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
grtlr
force-pushed
the
grtlr/graph-lod
branch
3 times, most recently
from
December 13, 2024 15:00
c5c4dd4
to
50ed438
Compare
abey79
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
I've reverted |
grtlr
force-pushed
the
grtlr/graph-lod
branch
from
December 16, 2024 09:57
50ed438
to
813ad48
Compare
Co-authored-by: Antoine Beyeler <[email protected]>
Co-authored-by: Antoine Beyeler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
@emilk and I discussed level-of-details on the graph. Here is an initial experiment.
Overall, I'm not sure the performance improvements warrant this addition.
Discussion + video: https://rerunio.slack.com/archives/C041NHU952S/p1734084741247629