Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement level-of-detail on text labels #8450

Merged
merged 6 commits into from
Dec 16, 2024
Merged

Implement level-of-detail on text labels #8450

merged 6 commits into from
Dec 16, 2024

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented Dec 13, 2024

What

@emilk and I discussed level-of-details on the graph. Here is an initial experiment.

Overall, I'm not sure the performance improvements warrant this addition.

Discussion + video: https://rerunio.slack.com/archives/C041NHU952S/p1734084741247629

@grtlr grtlr added the exclude from changelog PRs with this won't show up in CHANGELOG.md label Dec 13, 2024
Copy link

github-actions bot commented Dec 13, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
6b0e47d https://rerun.io/viewer/pr/8450 +nightly +main

Note: This comment is updated whenever you push a commit.

@grtlr grtlr force-pushed the grtlr/graph-lod branch 3 times, most recently from c5c4dd4 to 50ed438 Compare December 13, 2024 15:00
@grtlr grtlr requested a review from emilk December 13, 2024 15:00
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

crates/viewer/re_view_graph/src/ui/draw.rs Outdated Show resolved Hide resolved
crates/viewer/re_view_graph/src/ui/draw.rs Show resolved Hide resolved
crates/viewer/re_view_graph/src/ui/draw.rs Outdated Show resolved Hide resolved
@grtlr
Copy link
Contributor Author

grtlr commented Dec 16, 2024

I've reverted 50ed438 because it altered the graph too much for my liking.

@grtlr grtlr merged commit dd77aba into main Dec 16, 2024
31 checks passed
@grtlr grtlr deleted the grtlr/graph-lod branch December 16, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants