Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update egui to fix graph-view-resize-bug #8448

Closed
wants to merge 1 commit into from
Closed

Conversation

emilk
Copy link
Member

@emilk emilk commented Dec 13, 2024

Related

Updated to egui containing this fix:

What

Fixes a bug where it was very difficult to resize graph views

@emilk emilk added dependencies concerning crates, pip packages etc exclude from changelog PRs with this won't show up in CHANGELOG.md egui Requires egui/eframe work feat-graph-view Everything related to the graph view labels Dec 13, 2024
Copy link

github-actions bot commented Dec 13, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
9eb6338 https://rerun.io/viewer/pr/8448 +nightly +main

Note: This comment is updated whenever you push a commit.

@grtlr
Copy link
Contributor

grtlr commented Dec 13, 2024

@emilk
Copy link
Member Author

emilk commented Dec 15, 2024

They are different issues.

#8457 is about grpah views sometimes blocking all interaction outside of them (e.g. clicking stuff in the selection panel).

This PR is about that thin resize-handle between graph views, which is a separate issue.

@teh-cmc
Copy link
Member

teh-cmc commented Dec 16, 2024

I see you've purposefully left some untagged TODOs in there, in this supposed to be a draft/do-not-merge?

@emilk emilk closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies concerning crates, pip packages etc egui Requires egui/eframe work exclude from changelog PRs with this won't show up in CHANGELOG.md feat-graph-view Everything related to the graph view
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants