Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix out of bounds access in data density graph #8441

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Fix out of bounds access in data density graph #8441

merged 1 commit into from
Dec 13, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Dec 12, 2024

Regressed this somewhat recently during perf optimizations in the data_density_graph: it was possible to get into an out of bounds access when zooming in.
Cleaned it up a bit overall and fixed a subtle bug for when there's only fractional buckets filled in the density graph

@Wumpf Wumpf added 💣 crash crash, deadlock/freeze, do-no-start 🦟 regression A thing that used to work in an earlier release exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ 598b4ee https://rerun.io/viewer/pr/8441 +nightly +main

Note: This comment is updated whenever you push a commit.

abey79
abey79 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not on top of all the minute logic there, but I trust you and code lgtm :)

@teh-cmc
Copy link
Member

teh-cmc commented Dec 13, 2024

I see 🟢, I ship

@teh-cmc teh-cmc merged commit 98152a7 into main Dec 13, 2024
37 checks passed
@teh-cmc teh-cmc deleted the andreas/fix-timeline-crash branch December 13, 2024 08:20
grtlr pushed a commit that referenced this pull request Dec 13, 2024
@Wumpf @grtlr
Fix out of bounds access in data density graph (#8441)
3e8e4ed 
Regressed this somewhat recently during perf optimizations in the
data_density_graph: it was possible to get into an out of bounds access
when zooming in.
Cleaned it up a bit overall and fixed a subtle bug for when there's only
fractional buckets filled in the density graph
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
💣 crash crash, deadlock/freeze, do-no-start exclude from changelog PRs with this won't show up in CHANGELOG.md 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wumpf @teh-cmc @abey79