-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port codegen arrow deserialization to arrow-rs #8375
Draft
emilk
wants to merge
5
commits into
main
Choose a base branch
from
emilk/arrow-deserializer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
🏹 arrow
concerning arrow
🚜 refactor
Change the code, not the functionality
codegen/idl
exclude from changelog
PRs with this won't show up in CHANGELOG.md
labels
Dec 9, 2024
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
emilk
force-pushed
the
emilk/arrow-deserializer
branch
from
December 18, 2024 14:06
0ec5a67
to
b329d4a
Compare
emilk
force-pushed
the
emilk/arrow-deserializer
branch
from
December 18, 2024 16:05
f84e718
to
3e792d2
Compare
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12410292950 |
abey79
changed the title
Port codegen arrow deserializtion to arrow-rs
Port codegen arrow deserialization to arrow-rs
Dec 19, 2024
Heads up: full check is failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🏹 arrow
concerning arrow
codegen/idl
exclude from changelog
PRs with this won't show up in CHANGELOG.md
🚜 refactor
Change the code, not the functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
re_arrow2
toarrow
#3741Blocked by Add unsafe/unchecked slice functions apache/arrow-rs#6901What
Port arrow deserialization codegen to arrow-rs
Unfortunately something broke in the tensor deserialization, likely due to interior mutability:
TensorDimension
into shape and names #6830TODO
@rerun-bot full-check