Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing opened_application/recording_id in external data loader example #8191

Open
EtaLoop opened this issue Nov 20, 2024 · 2 comments
Open
Assignees
Labels
🪳 bug Something isn't working examples Issues relating to the Rerun examples

Comments

@EtaLoop
Copy link
Contributor

EtaLoop commented Nov 20, 2024

I tried to log data using an external data loader, with log_file_from_path and I got en error.

So I tried to test the loader for rust files (https://github.com/rerun-io/rerun/tree/main/examples/rust/external_data_loader) and I got the same error :

ERROR re_data_loader::loader_external] Failed to execute external loader filepath="file.rs" loader="rerun/target/release/rerun-loader-rust-file" reason=Unrecognized argument: --opened-application-id

With this code :

rec = rr.new_recording(application_id="My window", recording_id="My rec", spawn=True)
rr.log_file_from_path(file_path="file.rs", recording=rec.to_native())

So I add opened_application_id and opened_recording_id to

Now this works.

@EtaLoop EtaLoop added 👀 needs triage This issue needs to be triaged by the Rerun team 🪳 bug Something isn't working labels Nov 20, 2024
@teh-cmc teh-cmc added this to the Next patch release milestone Nov 20, 2024
@Wumpf Wumpf added examples Issues relating to the Rerun examples and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Nov 21, 2024
@EtaLoop
Copy link
Contributor Author

EtaLoop commented Dec 12, 2024

I put another external data loader that doesn't work here, to be sure to test it when the bug will be fixed.

https://github.com/rerun-io/rerun-loader-python-example-urdf

@teh-cmc
Copy link
Member

teh-cmc commented Dec 12, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working examples Issues relating to the Rerun examples
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants