Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC spec and codec update - add support for arrow metadata #7907

Merged
merged 10 commits into from
Oct 28, 2024

Conversation

zehiko
Copy link
Contributor

@zehiko zehiko commented Oct 25, 2024

What

Metadata associated with remote store recording will have some mandatory fields and additional arbitrary fields that we represent as arrow single row record batch.

When fetching metadata from the store about the recording, we expect to get back just the single row record batch that will have both the mandatory columns and any additional columns as defined during registration and subsequent updates.

We rely on codec for simple serialization and serialization of this data, which once again relies on arrow ipc.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@zehiko zehiko added exclude from changelog PRs with this won't show up in CHANGELOG.md remote-store remote store gRPC API labels Oct 25, 2024
@zehiko zehiko self-assigned this Oct 25, 2024
Copy link

Deployed docs

Commit Link
ff86342 https://landing-d4f4pyizi-rerun.vercel.app/docs

@jleibs
Copy link
Member

jleibs commented Oct 25, 2024

This looks reasonable to me.

@zehiko zehiko changed the title Draft: gRPC spec and codec update - add support for arrow metadata gRPC spec and codec update - add support for arrow metadata Oct 28, 2024
@zehiko zehiko merged commit 2383754 into main Oct 28, 2024
35 checks passed
@zehiko zehiko deleted the zehiko/register-metadata branch October 28, 2024 08:57
emilk added a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md remote-store remote store gRPC API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants