-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC spec and codec update - add support for arrow metadata #7907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zehiko
added
exclude from changelog
PRs with this won't show up in CHANGELOG.md
remote-store
remote store gRPC API
labels
Oct 25, 2024
Deployed docs
|
This looks reasonable to me. |
zehiko
changed the title
Draft: gRPC spec and codec update - add support for arrow metadata
gRPC spec and codec update - add support for arrow metadata
Oct 28, 2024
teh-cmc
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
exclude from changelog
PRs with this won't show up in CHANGELOG.md
remote-store
remote store gRPC API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Metadata associated with remote store recording will have some mandatory fields and additional arbitrary fields that we represent as arrow single row record batch.
When fetching metadata from the store about the recording, we expect to get back just the single row record batch that will have both the mandatory columns and any additional columns as defined during registration and subsequent updates.
We rely on codec for simple serialization and serialization of this data, which once again relies on arrow ipc.
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.