Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Z Hover Position in 2D view #7763

Open
slyfox3 opened this issue Oct 16, 2024 · 1 comment
Open

Wrong Z Hover Position in 2D view #7763

slyfox3 opened this issue Oct 16, 2024 · 1 comment
Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself

Comments

@slyfox3
Copy link

slyfox3 commented Oct 16, 2024

See the screenshot. The hover position contains a non-zero z value in a 2D view.

To Reproduce
Log a Points2D with hundreds points, and hover on them.

def _logScatter(samples: List[float], entity_prefix: str, static: bool, width: float):
    n = len(samples)
    half_width = width / 2.0
    radii = width / 20.0
    xs = [random.uniform(-half_width, half_width) for _ in range(n)]
    rr.log(
        f"{entity_prefix}/scatter",
        rr.Points2D(
            list(zip(xs, samples)),
            radii=radii,
        ),
        static=static,
    )

Expected behavior
Hover position is also 2D instead of 3D.

Screenshots
image

@slyfox3 slyfox3 added 👀 needs triage This issue needs to be triaged by the Rerun team 🪳 bug Something isn't working labels Oct 16, 2024
@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Oct 16, 2024
@Wumpf
Copy link
Member

Wumpf commented Oct 16, 2024

Looks like an implementation detail is leaking here on how we arrange things in 2D spaces!
This might yet turn out to be tricky: 3D objects in 2d ofc do have a 3D position, so we should show 3d positions for those and 2d positions for "true" 2d things (also interesting to check: are 3D hover positions for 3d objects even correct 😳? if not consider just always showing 2d as a stopgap solution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

No branches or pull requests

2 participants