-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always-on AV1 in --release
; opt-in to nasm-optimizations
#7661
Conversation
Deployed docs
|
Can a python & pip user get the nasm optimization without compiling form source? If not, it probably shouldn't be a prominent warning |
The The warning is for users that do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title a bit misleading. It's still off on debug
how are we building the standalone executables that we upload to GH? Those should also get that feature flag |
Good question. I'v created a separate issue for it: |
--release
; opt-in to nasm-optimizations
What
Even without
nasm
, it is pretty fast.I also added a warning to the user that they can get more performance by enabling the
nasm
feature.Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.