Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APIs for recording_id and application_id #7642

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Oct 8, 2024

What

Needed to track the StoreId on the ChunkStore as well.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added 🐍 Python API Python logging API exclude from changelog PRs with this won't show up in CHANGELOG.md feat-dataframe-api Everything related to the dataframe API labels Oct 8, 2024
@jleibs jleibs marked this pull request as ready for review October 8, 2024 16:46
@Wumpf
Copy link
Member

Wumpf commented Oct 8, 2024

why exclude from changelog? seems like a nice userfacing addition

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks convenient!

@jleibs
Copy link
Member Author

jleibs commented Oct 8, 2024

why exclude from changelog? seems like a nice userfacing addition

Incremental changes to a new API surface before that API surface has been exposed are in a bit of a gray area. Don't feel strongly either way.

@jleibs jleibs merged commit 0acab6d into main Oct 8, 2024
37 of 40 checks passed
@jleibs jleibs deleted the jleibs/dataframe_recording_id branch October 8, 2024 21:44
@abey79
Copy link
Member

abey79 commented Oct 9, 2024

why exclude from changelog? seems like a nice userfacing addition

It would be neat to have our changelog script generate a single line for new feature, followed by a massive dump of all PR numbers involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md feat-dataframe-api Everything related to the dataframe API 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Recording.get_{recording|app}_id()
3 participants