Have alternating background stripes also in expanded rows in the dataframe view #7412
Labels
🧑🎨 Design
Requires UX/UI designer input
feat-dataframe-view
Everything related to the dataframe view
ui
concerns graphical user interface
Milestone
Comments
abey79
added
ui
abey79
changed the title
6 tasks
abey79
added a commit
that referenced
this issue
Sep 17, 2024
…7400) ### What - Closes #7066 This PR introduces the ability to expend dataframe view rows to inspect individual instances. Note: expanding instance can potentially lead to very loooong tables. This doesn't affect performance as we only query/draw what is visible on screen, it means we reaching the limits of egui's `f32` numerical precision. This can lead to uneven scrolling or even visual glitches if the number of instance is >>1M. Follow-up todo: - #7412 https://github.com/user-attachments/assets/6801a8a8-667f-43b5-9581-bebcea80882b ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7400?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7400?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7400) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
|
I'm not sure that expanding one row into multiple lines should change the background stripes of existing rows. That might just be confusing. Maybe it is better to sometimes have double-stripes, or stripe expanded rows differently |
|
Actually, that has already landed with #7066 (so I'm going to close this issue). I had the exact same thought when implementing that, but I noticed because everything shifts up and down when rows are expanded/collapsed, it's extremely difficult to notice the "stripe inversion" on subsequent rows. So we're pretty good as is imo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should have background stripes everywhere. This means we must compute the odd-ness for rows (and sub-rows) on the fly, based on the expansion cache.
The text was updated successfully, but these errors were encountered: