Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI job sometime get stuck for a long time on some cargo doc steps #7387

Closed
abey79 opened this issue Sep 10, 2024 · 2 comments · Fixed by #7399
Closed

CI job sometime get stuck for a long time on some cargo doc steps #7387

abey79 opened this issue Sep 10, 2024 · 2 comments · Fixed by #7399
Assignees
@Wumpf
Labels
😤 annoying Something in the UI / SDK is annoying to use 🚢 CI

Comments

@abey79
Copy link
Member

abey79 commented Sep 10, 2024 •
edited
Loading

Happened to me many times lately. e.g. https://github.com/rerun-io/rerun/actions/runs/10787136673/job/29915256091?pr=7386 (completed in 42 minutes)
@abey79 abey79 added 🚢 CI 😤 annoying Something in the UI / SDK is annoying to use labels Sep 10, 2024
@abey79 abey79 changed the title CI job sometime get stuck and takes 42 min to complete CI job sometime get stuck and takes very long to complete Sep 10, 2024
@Wumpf
Copy link
Member

Wumpf commented Sep 10, 2024 

 1070.24s 	 cargo doc --quiet --no-deps --all-features --workspace
1069.07s 	 cargo doc --quiet --document-private-items --no-deps --all-features --workspace

Looks like we're hitting a bug in cargo docs. Might be the same we fought with in wgpu (the "solution" there ended up being a major overhaul of wgpu-core to use less generics ;-))

@abey79 abey79 changed the title CI job sometime get stuck and takes very long to complete CI job sometime get stuck for a long time on some cargo doc steps Sep 10, 2024
@Wumpf
Copy link
Member

Wumpf commented Sep 11, 2024

It's likely (but not certainly) related to this issue which was the one that caused us so much grief in wgpu:

@Wumpf Wumpf self-assigned this Sep 11, 2024
@Wumpf Wumpf mentioned this issue Sep 11, 2024
Merged
6 tasks
emilk pushed a commit that referenced this issue Sep 11, 2024
@Wumpf
Split out (ultra-)slow cargo doc jobs and run them only on nightly (#…
8ddd84f 
…7399)

### What

* Fixes #7387
    * well, sort of ;)

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7399?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7399?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7399)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
jprochazk pushed a commit that referenced this issue Sep 11, 2024
@Wumpf @jprochazk
Split out (ultra-)slow cargo doc jobs and run them only on nightly (#…
cbe8467 
…7399)

### What

* Fixes #7387
    * well, sort of ;)

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7399?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7399?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7399)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
😤 annoying Something in the UI / SDK is annoying to use 🚢 CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split out (ultra-)slow cargo doc jobs and run them only on nightly rerun-io/rerun
2 participants
@Wumpf @abey79