Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support columns with variable partitions in Rust's send_column api #7167

Open
Wumpf opened this issue Aug 13, 2024 · 2 comments
Open

Support columns with variable partitions in Rust's send_column api #7167

Wumpf opened this issue Aug 13, 2024 · 2 comments
Labels
🪵 Log & send APIs Affects the user-facing API for all languages 🦀 Rust API Rust logging API

Comments

@Wumpf
Copy link
Member

Wumpf commented Aug 13, 2024

Both Python & C++ APIs have ways of partitioning a component column arbitrarily to e.g. log point clouds in a single send_columns call.
Rust however, right now only supports partitions of length 1 for each element (i.e. at each timestep you end up with an array of length 1) which is still great for the usecase of sending e.g. Scalar, but not the full picture.

Note that the lower level send_chunk API that the Rust recording stream comes with has none such restrictions (and is what is used by Python and C++).

@Wumpf Wumpf added 🦀 Rust API Rust logging API 🪵 Log & send APIs Affects the user-facing API for all languages labels Aug 13, 2024
@teh-cmc
Copy link
Member

teh-cmc commented Oct 22, 2024

If it's not outright blocked by, it would at the very least heavily benefit from:

which needs to happen multi-datatype tagged components anyhow.

@teh-cmc
Copy link
Member

teh-cmc commented Dec 3, 2024

Somewhat related, the Rust definition of send_columns seems wrong not optimal:

    pub fn send_columns<'a>(
        &self,
        ent_path: impl Into<EntityPath>,
        timelines: impl IntoIterator<Item = TimeColumn>,
        components: impl IntoIterator<Item = &'a dyn re_types_core::ComponentBatch>,
    ) -> RecordingStreamResult<()> {

Why take an iterator of ComponentBatches instead of the more flexible AsComponents?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪵 Log & send APIs Affects the user-facing API for all languages 🦀 Rust API Rust logging API
Projects
None yet
Development

No branches or pull requests

2 participants