Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify / unify instancing behavior of Mesh/Asset3D/Boxes/Ellipsoids #7058

Closed
Wumpf opened this issue Aug 5, 2024 · 0 comments · Fixed by #7119
Closed

Clarify / unify instancing behavior of Mesh/Asset3D/Boxes/Ellipsoids #7058

Wumpf opened this issue Aug 5, 2024 · 0 comments · Fixed by #7119
Assignees
Labels
💬 discussion 🍏 primitives Relating to Rerun primitives 📺 re_viewer affects re_viewer itself

Comments

@Wumpf
Copy link
Member

Wumpf commented Aug 5, 2024

More concrete incarnation of

As of writing Mesh & Asset3D will draw additional instances if there's more than one of LeafTransform3D components.

On the flip side Boxes3D and Ellipsoids3D will only draw as many boxes/ellipsoids ad there are HalfSize3D elements. Any additional LeafTransform3D components are ignored.

This is a bit inconsistent! Should we keep splatting out boxes/ellipsoids for each leaf transform or is Mesh/Asset's behavior not what we want after all?

Note that implementation of all of these isn't too challening, rather easy. We have to make a consistent & documented decision though. Ui is a bit more tricky to get right though (what does it mean to select the n'th index/instance?), we may want to create follow-up issues for that if needed.

@Wumpf Wumpf added 💬 discussion 📺 re_viewer affects re_viewer itself 🍏 primitives Relating to Rerun primitives labels Aug 5, 2024
@Wumpf Wumpf added this to the 0.18 - MHz logging milestone Aug 5, 2024
@Wumpf Wumpf self-assigned this Aug 8, 2024
@Wumpf Wumpf closed this as completed in 923c152 Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💬 discussion 🍏 primitives Relating to Rerun primitives 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant