Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the extra StoreInfo from memory_sink #6207

Merged
merged 1 commit into from
May 2, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented May 2, 2024

What

Fixes a test failure on main.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs marked this pull request as ready for review May 2, 2024 20:08
@jleibs jleibs added 🔨 testing testing and benchmarks 🦟 regression A thing that used to work in an earlier release exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 2, 2024
@jleibs
Copy link
Member Author

jleibs commented May 2, 2024

@rerun-bot full-check

Copy link

github-actions bot commented May 2, 2024

Started a full build: https://github.com/rerun-io/rerun/actions/runs/8929987528

@jleibs
Copy link
Member Author

jleibs commented May 2, 2024

Merging since main is broken. Post-review welcome.

@jleibs jleibs merged commit a9c9706 into main May 2, 2024
69 of 71 checks passed
@jleibs jleibs deleted the jleibs/mem_recording_redundant_store_info branch May 2, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🦟 regression A thing that used to work in an earlier release 🔨 testing testing and benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant