Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wgpu/winit/egui as soon as 0.16 is out #6170

Closed
2 of 3 tasks
teh-cmc opened this issue Apr 30, 2024 · 1 comment · Fixed by #6171
Closed
2 of 3 tasks

Update wgpu/winit/egui as soon as 0.16 is out #6170

teh-cmc opened this issue Apr 30, 2024 · 1 comment · Fixed by #6171
Assignees
@Wumpf
Labels
dependencies concerning crates, pip packages etc ⛴ release Related to shipping or publishing

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Apr 30, 2024 •
edited by Wumpf
Loading

As @Wumpf said:

We decided on post-standup not to update wgpu/winit/egui before the release in order to not drag it out and accumulate more risky changes.

We should be ready to merge all of that ASAP once 0.16 is out though, this needs as much soak time as we can get.

TODO:

  • wgpu PR ready
  • winit PR ready
  • egui PR ready
@teh-cmc teh-cmc added dependencies concerning crates, pip packages etc ⛴ release Related to shipping or publishing labels Apr 30, 2024
@Wumpf Wumpf assigned emilk and Wumpf Apr 30, 2024
@teh-cmc teh-cmc modified the milestones: Blueprint from code, 0.16 Apr 30, 2024
@Wumpf Wumpf mentioned this issue Apr 30, 2024
Merged
18 tasks
@emilk emilk removed their assignment May 6, 2024
@emilk emilk removed this from the 0.16 milestone May 6, 2024
@Wumpf Wumpf linked a pull request Jun 14, 2024 that will close this issue
Update to wgpu 0.20, fixing crashes with some linux setups #6171
Merged
18 tasks
@Wumpf
Copy link
Member

Wumpf commented Jun 14, 2024

looks like we'll take winit in the release after

Wumpf added a commit that referenced this issue Jun 14, 2024
@Wumpf
Update to wgpu 0.20, fixing crashes with some linux setups (#6171)
8382c27 
### What

* Part of #6170
* Based on emilk/egui#4433
* Makes it possible to handle
#5968
* it no longer is a crash but an _okish_ error message (more to do
still)
 * Fixes #5283
    * [x] @jleibs can you confirm?


Test on:
* Mac
    * [x] native
    * [x] Firefox WebGL
    * [x] Chrome WebGPU
    * [x] Chrome WebGL 
* Windows
    * [x] native
    * [x] Firefox WebGL
    * [x] Chrome WebGPU
    * [x] Chrome WebGL 
* Linux
    * [x] native
    * [x] Firefox WebGL
    * [x] Chrome WebGPU
* needs both chrome://flags/#enable-unsafe-webgpu &
chrome://flags/#enable-vulkan flags set (via
https://developer.chrome.com/docs/web-platform/webgpu/troubleshooting-tips)
    * [x] Chrome WebGL 

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6171?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6171?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6171)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
dependencies concerning crates, pip packages etc ⛴ release Related to shipping or publishing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to wgpu 0.20, fixing crashes with some linux setups rerun-io/rerun
3 participants
@emilk @Wumpf @teh-cmc