Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset3D supports transform argument, but Mesh3D does not #4901

Open
roym899 opened this issue Jan 24, 2024 · 1 comment
Open

Asset3D supports transform argument, but Mesh3D does not #4901

roym899 opened this issue Jan 24, 2024 · 1 comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🔩 data model 🏎️ Quick Issue Can be fixed in a few hours or less
Milestone

Comments

@roym899
Copy link
Collaborator

roym899 commented Jan 24, 2024

Minor issue since it can easily be worked around by manually transforming or logging a separate transform.

To be honest, not sure why Asset3D supports it. However, I think it is nice to have for simplicity.

Maybe worth considering whether other archetypes like Points3D should also support this argument.

@roym899 roym899 added 😤 annoying Something in the UI / SDK is annoying to use 👀 needs triage This issue needs to be triaged by the Rerun team labels Jan 24, 2024
@teh-cmc
Copy link
Member

teh-cmc commented Jan 24, 2024

To be honest, not sure why Asset3D supports it.

Because they are different things: the transform you log independently is an in-tree transform while the one attached to Asset3D is an out-of-tree transform... which is a concept that we've talked about a lot and never fully agreed on whether nor how to generalize it, which is why it only exists in a couple places at the moment and so it gets very confusing... 😞

See:

@Wumpf Wumpf added 🏎️ Quick Issue Can be fixed in a few hours or less 🔩 data model and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Mar 11, 2024
@Wumpf Wumpf added this to the Triage milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🔩 data model 🏎️ Quick Issue Can be fixed in a few hours or less
Projects
None yet
Development

No branches or pull requests

3 participants