-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewer should be able to stream in .rrd
files whilst they're still being written to
#4056
Labels
🧑💻 dev experience
developer experience (excluding CI)
📺 re_viewer
affects re_viewer itself
user-request
This is a pressing issue for one of our users
Comments
teh-cmc
added
🧑💻 dev experience
developer experience (excluding CI)
📺 re_viewer
affects re_viewer itself
user-request
This is a pressing issue for one of our users
labels
Oct 28, 2023
This was referenced Jan 16, 2024
emilk
changed the title
Viewer should read files in a streaming fashion
Viewer should be able to stream in Apr 24, 2024
.rrd
files whilst they're still being written to
I just tried this with Rerun 0.18.2. The viewer can read from |
Quick summary of the issue:
Had a quick chat with Emil on the path forward and we discussed following steps:
|
zehiko
added a commit
that referenced
this issue
Sep 20, 2024
We stop streaming data from an .rrd file that is still being written once we reach EOF. As a first simple remediation we introduce a retryable reader that will try to read more data from the file indefinitely.
zehiko
added a commit
that referenced
this issue
Sep 20, 2024
We stop streaming data from an .rrd file that is still being written once we reach EOF. As a first simple remediation we introduce a retryable reader that will try to read more data from the file indefinitely.
6 tasks
zehiko
added a commit
that referenced
this issue
Sep 24, 2024
Ensure we continue streaming .rrd file in the viewer as it's being written to (#4056) We introduce a retryable file reader that is used when reading .rrd files that are still being written and it simply ignored the EoF condition. We also introduce an end-of-stream message header that ensures we stop decoding (and endlessly trying to read the file) message stream once we see this header. .rrd files generated with using a prior sdk version should work just fine, the only downside is that while the viewer is running there will be an open file handle for that file since no end-of-stream message will exist.
Fixed as part of PR #7475. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🧑💻 dev experience
developer experience (excluding CI)
📺 re_viewer
affects re_viewer itself
user-request
This is a pressing issue for one of our users
We can log to files in a streaming fashion already today:
That's great, but we cannot visualize file recordings in a streaming fashion:
$ rerun /tmp/stream.rrd # will only show what it is there _right now_
The text was updated successfully, but these errors were encountered: