Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically derive nullable if not attr.rerun.component_required #2373

Closed
Tracked by #2646
teh-cmc opened this issue Jun 11, 2023 · 1 comment
Closed
Tracked by #2646

Automatically derive nullable if not attr.rerun.component_required #2373

teh-cmc opened this issue Jun 11, 2023 · 1 comment
Labels
codegen/idl 🏎️ Quick Issue Can be fixed in a few hours or less

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jun 11, 2023

No description provided.

@teh-cmc teh-cmc added good first issue Good for newcomers 🏎️ Quick Issue Can be fixed in a few hours or less codegen/idl labels Jun 11, 2023
@teh-cmc teh-cmc changed the title rerun.attr.component_required should automatically force the builtin required rerun.attr.component_required should automatically imply required Jun 11, 2023
@teh-cmc teh-cmc changed the title rerun.attr.component_required should automatically imply required Get rid of rerun.attr.component_* Jul 10, 2023
@teh-cmc teh-cmc changed the title Get rid of rerun.attr.component_* Automatically derive nullable if not attr.rerun.component_required Jul 10, 2023
@teh-cmc teh-cmc mentioned this issue Jul 10, 2023
Open
12 tasks
@nikolausWest nikolausWest removed the good first issue Good for newcomers label Jul 14, 2023
@Wumpf
Copy link
Member

Wumpf commented Oct 4, 2023

We decided otherwise by now and want to make even required components nullable. See #3381

@Wumpf Wumpf closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
codegen/idl 🏎️ Quick Issue Can be fixed in a few hours or less
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Wumpf @nikolausWest @teh-cmc