From a398980e46591a5db6300a9829c685759b04da10 Mon Sep 17 00:00:00 2001
From: Clement Rey <cr.rey.clement@gmail.com>
Date: Thu, 30 Nov 2023 10:33:17 +0100
Subject: [PATCH] note about smallvec

---
 crates/re_arrow_store/src/store_event.rs | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/crates/re_arrow_store/src/store_event.rs b/crates/re_arrow_store/src/store_event.rs
index 697d190dbddd1..0a9f02ace8c73 100644
--- a/crates/re_arrow_store/src/store_event.rs
+++ b/crates/re_arrow_store/src/store_event.rs
@@ -118,6 +118,10 @@ pub struct StoreDiff {
     /// same value for both the insertion and deletion events (if any).
     ///
     /// This is not a [`TimePoint`] for performance reasons.
+    //
+    // NOTE: Empirical testing shows that a SmallVec isn't any better in the best case, and can be a
+    // significant performant drop at worst.
+    // pub times: SmallVec<[(Timeline, TimeInt); 5]>, // "5 timelines ought to be enough for anyone"
     pub times: Vec<(Timeline, TimeInt)>,
 
     /// The [`EntityPath`] associated with that row.