Skip to content

Commit

Permalink
Fix: ./scripts/lint.py ignored all under crates/build (#8532)
Browse files Browse the repository at this point in the history
  • Loading branch information
emilk authored Dec 18, 2024
1 parent efcb2f5 commit 905c2fc
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ __MACOSX
*.bin
*.o
/arrow/
/build/
./build/
**/build-msvc/
**/CMakeFiles/
**/CMakeCache.txt
Expand Down
2 changes: 1 addition & 1 deletion crates/build/re_protos_builder/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ pub fn generate_rust_code(
std::process::exit(1);
}
_ => {
panic!("{err:?}");
panic!("{err}");
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion crates/build/re_types_builder/src/codegen/rust/arrow.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use quote::quote;
/// `(Datatype, is_recursive)`
///
/// If `is_recursive` is set to `true`,
/// then the generate code will often be shorter, as it it will
/// then the generated code will often be shorter, as it will
/// defer to calling `arrow_datatype()` on the inner type.
pub struct ArrowDataTypeTokenizer<'a>(pub &'a ::arrow2::datatypes::DataType, pub bool);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -843,7 +843,7 @@ fn quote_arrow_field_serializer(
// if we make the C++ and Python codegen match the rust behavior or
// make our comparison tests more lenient.
//
// This workaround does not apply if we don't have any validity validity on the outer type.
// This workaround does not apply if we don't have any validity on the outer type.
// (as it is always the case with unions where the nullability is encoded as a separate variant)
let quoted_inner_validity = if let (true, DataType::FixedSizeList(_, count)) =
(elements_are_nullable, datatype.to_logical_type())
Expand Down

0 comments on commit 905c2fc

Please sign in to comment.